Bug 120235

Summary: Eliminate a useless comparison in srcset's candidate selection algorithm
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yoav Weiss
Reported 2013-08-23 14:17:50 PDT
Eliminate a useless comparison in srcset's candidate selection algorithm
Attachments
Patch (3.69 KB, patch)
2013-08-23 14:24 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (3.65 KB, patch)
2013-08-24 10:23 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2013-08-23 14:24:35 PDT
Created attachment 209510 [details] Patch
Yoav Weiss
Comment 2 2013-08-23 14:35:04 PDT
According to Darin Adler's comment (https://bugs.webkit.org/show_bug.cgi?id=120168#c12 ), I shortened the iteration on the candidates vector, to eliminate the comparison of the last candidate's qualifier to the DPR, since it will be returned in any case. I also removed the MIME types from the related tests, since their not relevant, and can cause the tests to fail.
Andreas Kling
Comment 3 2013-08-24 10:06:40 PDT
Comment on attachment 209510 [details] Patch r=me
WebKit Commit Bot
Comment 4 2013-08-24 10:08:25 PDT
Comment on attachment 209510 [details] Patch Rejecting attachment 209510 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 209510, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1558343
Yoav Weiss
Comment 5 2013-08-24 10:23:44 PDT
Created attachment 209545 [details] Patch
WebKit Commit Bot
Comment 6 2013-08-24 10:54:37 PDT
Comment on attachment 209545 [details] Patch Clearing flags on attachment: 209545 Committed r154548: <http://trac.webkit.org/changeset/154548>
WebKit Commit Bot
Comment 7 2013-08-24 10:54:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.