Bug 120234

Summary:

REGRESSION (r150516): Media controls are messed up on right-to-left webpages

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, macpherson, menard, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+, commit-queue: commit-queue-
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none

Jer Noble

Reported 2013-08-23 14:15:44 PDT

REGRESSION (r150516): Media controls are messed up on right-to-left webpages

Attachments
Patch (3.45 KB, patch) 2013-08-23 14:29 PDT, Jer Noble	mitz: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (586.83 KB, application/zip) 2013-08-23 15:43 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (772.89 KB, application/zip) 2013-08-23 15:48 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2013-08-23 14:16:35 PDT

<rdar://problem/14816232>

Jer Noble

Comment 2 2013-08-23 14:29:47 PDT

Created attachment 209511 [details] Patch

WebKit Commit Bot

Comment 3 2013-08-23 15:43:39 PDT

Comment on attachment 209511 [details] Patch Rejecting attachment 209511 [details] from commit-queue. New failing tests: media/video-rtl.html Full output: http://webkit-queues.appspot.com/results/1546410

WebKit Commit Bot

Comment 4 2013-08-23 15:43:40 PDT

Created attachment 209518 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Build Bot

Comment 5 2013-08-23 15:48:24 PDT

Comment on attachment 209511 [details] Patch Attachment 209511 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1558121 New failing tests: media/video-rtl.html

Build Bot

Comment 6 2013-08-23 15:48:26 PDT

Created attachment 209520 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Jer Noble

Comment 7 2013-08-23 15:50:32 PDT

Forgot to mark the media tests as generating pixel results. Will fix and land manually.

Jer Noble

Comment 8 2013-08-23 15:59:46 PDT

Committed r154529: <http://trac.webkit.org/changeset/154529>

Note You need to log in before you can comment on or make changes to this bug.