Bug 120231

Summary: Web Inspector: Fix js minification of updated CodeMirror
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-08-23 13:49:47 PDT
Oops. We'll have to work around this a bit better in the future, but lets fix this now.
Attachments
[PATCH] Proposed Fix (2.26 KB, patch)
2013-08-23 13:51 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-08-23 13:50:13 PDT
<rdar://problem/14822804>
Joseph Pecoraro
Comment 2 2013-08-23 13:51:59 PDT
Created attachment 209508 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2013-08-23 14:57:13 PDT
Comment on attachment 209508 [details] [PATCH] Proposed Fix Clearing flags on attachment: 209508 Committed r154524: <http://trac.webkit.org/changeset/154524>
WebKit Commit Bot
Comment 4 2013-08-23 14:57:14 PDT
All reviewed patches have been landed. Closing bug.
Timothy Hatcher
Comment 5 2013-08-24 08:14:25 PDT
I tried to submit a similar change to CodeMirror so we would keep having this issue. But he didn't want a workaround. We likely need to switch minifier scripts to fix this.
Note You need to log in before you can comment on or make changes to this bug.