Bug 120191 – Editable text nodes should be have EditableTextRole

• Component: Accessibility
• Status: RESOLVED INVALID

[Roger Fong]

previously they were considered static text.

[Radar WebKit Bug Importer]

<rdar://problem/14815202>

[Roger Fong]

I'm going to add 
+    if (node()->isTextNode() && node()->isContentEditable())
+        return EditableTextRole;
to determineAccessibilityRole in AccessibilityNodeObject.cpp

[chris fleizach]

On the Mac, I believe we mark these are what they normally are (DivRole, or GroupRole) but we mark that the value is writable. VO has some good to handle that then.

I think this change is OK, but it will cause some failures in Mac and maybe others because this role will need to be handled the right way to return the right platform specific role

[Roger Fong]

Created attachment 209477 [details]
patch

[chris fleizach]

Comment on attachment 209477 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209477&action=review

> accessibility/AccessibilityNodeObject.cpp:281
> +        return EditableTextRole;

this should probably go inside the next line so we have
if (node()->isTextNode()) {
   if (node()->isContent())
      return Editable
   return Static
}

[Roger Fong]

(In reply to comment #3)
> On the Mac, I believe we mark these are what they normally are (DivRole, or GroupRole) but we mark that the value is writable. VO has some good to handle that then.
> 
> I think this change is OK, but it will cause some failures in Mac and maybe others because this role will need to be handled the right way to return the right platform specific role

How about I add a isTextNode() && isContentEditable() check to AccessibleBase (windows specific) where I decide to create the AccessibleText instance.

That way I won't have to modify this platform agnostic stuff.
That sound okay?

[chris fleizach]

(In reply to comment #6)
> (In reply to comment #3)
> > On the Mac, I believe we mark these are what they normally are (DivRole, or GroupRole) but we mark that the value is writable. VO has some good to handle that then.
> > 
> > I think this change is OK, but it will cause some failures in Mac and maybe others because this role will need to be handled the right way to return the right platform specific role
> 
> How about I add a isTextNode() && isContentEditable() check to AccessibleBase (windows specific) where I decide to create the AccessibleText instance.
> 
> That way I won't have to modify this platform agnostic stuff.
> That sound okay?

Sounds ok

[Roger Fong]

Will move this check into Windows specific code.

[Brent Fulgham]

Comment on attachment 209477 [details]
patch

Clearing flag to remove from review queue.