Bug 12019

Summary: Patch to make Qt Platform build again
Product: WebKit Reporter: Daniel Molkentin <molkentin>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch to make the Qt platform on Webkit build again
eric: review-
Added ChangeLog, removed useless PDFDocumentImage stub eric: review+

Daniel Molkentin
Reported 2006-12-28 16:52:40 PST
Patch from Fredrik Höglund <fredrik@kde.org>, extended by me (Daniel Molkentin <molkentin@kde.org>): * Fix font sizes * Make Qt plattform build again: * Adjust Qt platform to the Image class split. * Introduce BitmapImage class * add stub PDFDocumentImage class Patch attached.
Attachments
Patch to make the Qt platform on Webkit build again (15.19 KB, patch)
2006-12-28 16:54 PST, Daniel Molkentin 		eric: review-
DetailsFormatted DiffDiff
Added ChangeLog, removed useless PDFDocumentImage stub (11.96 KB, patch)
2006-12-28 17:42 PST, Daniel Molkentin 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Molkentin
Comment 1 2006-12-28 16:54:01 PST
Created attachment 12091 [details] Patch to make the Qt platform on Webkit build again
David Kilzer (:ddkilzer)
Comment 2 2006-12-28 17:07:34 PST
Comment on attachment 12091 [details] Patch to make the Qt platform on Webkit build again Setting review? flag.
Eric Seidel (no email)
Comment 3 2006-12-28 17:20:55 PST
Comment on attachment 12091 [details] Patch to make the Qt platform on Webkit build again There should be no need to add PDFDocumentImage. Otherwise the patch looks fine. You'll need to add a ChangeLog entry. prepare-ChangeLog (a perl script included in WebKitTools/Scripts) will generate a changelog stub entry for you.
Daniel Molkentin
Comment 4 2006-12-28 17:42:25 PST
Created attachment 12093 [details] Added ChangeLog, removed useless PDFDocumentImage stub
Eric Seidel (no email)
Comment 5 2006-12-28 18:10:16 PST
Comment on attachment 12093 [details] Added ChangeLog, removed useless PDFDocumentImage stub Looks great! r=me.
Eric Seidel (no email)
Comment 6 2006-12-28 18:13:03 PST
Landed in r18463.
Note You need to log in before you can comment on or make changes to this bug.