Bug 120183

Summary: WebCore fails to link due to changes in Objective-C++ ABI in trunk clang
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, commit-queue, darin, dfarler, kling, mrowe, tony, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126958    
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2013-08-22 17:14:38 PDT
The trunk version of clang made an ABI change for Objective-C++ parameters that caused WebCore to fail to link.  The short-term fix is to change the parameter type from id<protocol> to just id and add an ASSERT that the parameter still conforms to the protocol.
Comment 1 David Kilzer (:ddkilzer) 2013-08-22 17:15:38 PDT
<rdar://problem/14764114>
Comment 2 David Kilzer (:ddkilzer) 2013-08-22 17:19:20 PDT
Created attachment 209409 [details]
Patch v1
Comment 3 WebKit Commit Bot 2013-08-23 09:55:27 PDT
Comment on attachment 209409 [details]
Patch v1

Clearing flags on attachment: 209409

Committed r154493: <http://trac.webkit.org/changeset/154493>
Comment 4 WebKit Commit Bot 2013-08-23 09:55:30 PDT
All reviewed patches have been landed.  Closing bug.