Bug 120166

Summary:

Add Traversal<ElementType> template

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, kling, rniwa, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	webkit-ews: commit-queue-
another	none
yet another	none
yet yet another	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
more	kling: review+

Antti Koivisto

Reported 2013-08-22 12:02:39 PDT

It is common to traverse through a subtree looking for elements of specific type and then casting to the type. This pattern can be generalized.

Attachments
patch (64.53 KB, patch) 2013-08-22 12:11 PDT, Antti Koivisto	webkit-ews: commit-queue-	Details Formatted Diff Diff
another (67.56 KB, patch) 2013-08-22 13:53 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
yet another (66.37 KB, patch) 2013-08-22 15:27 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
yet yet another (66.42 KB, patch) 2013-08-22 16:17 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (523.72 KB, application/zip) 2013-08-22 17:24 PDT, Build Bot	no flags	Details
more (66.39 KB, patch) 2013-08-23 00:09 PDT, Antti Koivisto	kling: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2013-08-22 12:11:08 PDT

Created attachment 209383 [details] patch

Early Warning System Bot

Comment 2 2013-08-22 12:19:27 PDT

Comment on attachment 209383 [details] patch Attachment 209383 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1546032

Early Warning System Bot

Comment 3 2013-08-22 12:20:09 PDT

Comment on attachment 209383 [details] patch Attachment 209383 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1543084

EFL EWS Bot

Comment 4 2013-08-22 12:20:12 PDT

Comment on attachment 209383 [details] patch Attachment 209383 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1527350

Antti Koivisto

Comment 5 2013-08-22 13:53:09 PDT

Created attachment 209390 [details] another

Antti Koivisto

Comment 6 2013-08-22 15:27:41 PDT

Created attachment 209398 [details] yet another

Antti Koivisto

Comment 7 2013-08-22 16:17:25 PDT

Created attachment 209403 [details] yet yet another

Build Bot

Comment 8 2013-08-22 17:24:46 PDT

Comment on attachment 209403 [details] yet yet another Attachment 209403 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1555063 New failing tests: fast/parser/style-in-create-contextual-fragment-head.html fast/workers/termination-with-port-messages.html fast/parser/style-in-create-contextual-fragment.html

Build Bot

Comment 9 2013-08-22 17:24:47 PDT

Created attachment 209411 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4

Antti Koivisto

Comment 10 2013-08-23 00:09:15 PDT

Created attachment 209440 [details] more

Andreas Kling

Comment 11 2013-08-23 04:48:47 PDT

Comment on attachment 209440 [details] more r=me We really should auto-generate the isFooElement() helpers.

Antti Koivisto

Comment 12 2013-08-23 05:41:02 PDT

https://trac.webkit.org/r154481

Note You need to log in before you can comment on or make changes to this bug.