Bug 120165

Summary: Web Inspector: Update CodeMirror to 3.16.1
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-08-22 11:52:37 PDT
Update of CodeMirror to get "gutterContextMenu" event. Updating the CodeMirror Resources is mostly automated: 1. Update local CodeMirror checkout ($codemirror) shell> cd $codemirror; git pull --rebase 2. Update WebInspectorUI CodeMirror resources: shell>./Source/WebInspectorUI/Scripts/update-codemirror-resources.rb $codemirror 3. Update WebInspectorUI Tools/PrettyPrintingr CodeMirror resources and run tests: shell>./Source/WebInspectorUI/Scripts/update-pretty-printer.rb Tools shell> open ./Source/WebInspectorUI/Tools/PrettyPrinting/index.html # run tests in the UI 4. Do some manual testing of the inspector to make sure things work as expected
Attachments
[PATCH] Proposed Fix (78.01 KB, patch)
2013-08-22 11:55 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-08-22 11:52:58 PDT
<rdar://problem/14810479>
Joseph Pecoraro
Comment 2 2013-08-22 11:55:10 PDT
Created attachment 209381 [details] [PATCH] Proposed Fix • All Tools/PrettyPrinting tests passed. • General testing looked good (Styles sidebar, Console prompt, CSS Resource editing)
WebKit Commit Bot
Comment 3 2013-08-22 12:27:54 PDT
Comment on attachment 209381 [details] [PATCH] Proposed Fix Clearing flags on attachment: 209381 Committed r154456: <http://trac.webkit.org/changeset/154456>
WebKit Commit Bot
Comment 4 2013-08-22 12:27:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.