Bug 120158

Summary:

FrameLoader: frame() and client() should return references.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Page Loading

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eflews.bot, gtk-ews, gyuyoung.kim, kling, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+, webkit-ews: commit-queue-
Patch für landing	gtk-ews: commit-queue-
Patch för landing	none

Andreas Kling

Reported 2013-08-22 06:09:11 PDT

...as they are always present.

Attachments
Patch (186.84 KB, patch) 2013-08-22 06:12 PDT, Andreas Kling	andersca: review+ webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch für landing (188.71 KB, patch) 2013-08-22 08:08 PDT, Andreas Kling	gtk-ews: commit-queue-	Details Formatted Diff Diff
Patch för landing (190.94 KB, patch) 2013-08-22 08:43 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-08-22 06:12:49 PDT

Created attachment 209355 [details] Patch

Early Warning System Bot

Comment 2 2013-08-22 06:24:07 PDT

Comment on attachment 209355 [details] Patch Attachment 209355 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1545120

Early Warning System Bot

Comment 3 2013-08-22 06:27:23 PDT

Comment on attachment 209355 [details] Patch Attachment 209355 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1384977

kov's GTK+ EWS bot

Comment 4 2013-08-22 06:36:38 PDT

Comment on attachment 209355 [details] Patch Attachment 209355 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1424090

EFL EWS Bot

Comment 5 2013-08-22 06:47:43 PDT

Comment on attachment 209355 [details] Patch Attachment 209355 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1492110

Andreas Kling

Comment 6 2013-08-22 08:08:30 PDT

Created attachment 209368 [details] Patch für landing

kov's GTK+ EWS bot

Comment 7 2013-08-22 08:19:35 PDT

Comment on attachment 209368 [details] Patch für landing Attachment 209368 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1549103

Andreas Kling

Comment 8 2013-08-22 08:43:23 PDT

Created attachment 209371 [details] Patch för landing

Andreas Kling

Comment 9 2013-08-22 09:00:48 PDT

Committed r154449: <http://trac.webkit.org/changeset/154449>

Csaba Osztrogonác

Comment 10 2013-08-22 09:41:51 PDT

Comment on attachment 209371 [details] Patch för landing View in context: https://bugs.webkit.org/attachment.cgi?id=209371&action=review > Source/WebCore/rendering/RenderWidget.cpp:122 > + RenderObject::destroy(); > +#if 0 > willBeDestroyed(); > > // Grab the arena from node()->document()->renderArena() before clearing the node pointer. It seems it made all tests assert: STDOUT: main frame - didStartProvisionalLoadForFrame STDERR: ASSERTION FAILED: m_refCount <= 0 STDERR: /ramdisk/qt-linux-32-debug/build/Source/WebCore/rendering/RenderWidget.cpp(132) : virtual WebCore::RenderWidget::~RenderWidget()

Andreas Kling

Comment 11 2013-08-22 09:45:13 PDT

(In reply to comment #10) > (From update of attachment 209371 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209371&action=review > > > Source/WebCore/rendering/RenderWidget.cpp:122 > > + RenderObject::destroy(); > > +#if 0 > > willBeDestroyed(); > > > > // Grab the arena from node()->document()->renderArena() before clearing the node pointer. > > It seems it made all tests assert: > > STDOUT: main frame - didStartProvisionalLoadForFrame > STDERR: ASSERTION FAILED: m_refCount <= 0 > STDERR: /ramdisk/qt-linux-32-debug/build/Source/WebCore/rendering/RenderWidget.cpp(132) : virtual WebCore::RenderWidget::~RenderWidget() <https://trac.webkit.org/r154452>

Note You need to log in before you can comment on or make changes to this bug.