Bug 120158

Summary: FrameLoader: frame() and client() should return references.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Page LoadingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gtk-ews, gyuyoung.kim, kling, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+, webkit-ews: commit-queue-
Patch für landing
gtk-ews: commit-queue-
Patch för landing none

Description Andreas Kling 2013-08-22 06:09:11 PDT 
...as they are always present.
Comment 1 Andreas Kling 2013-08-22 06:12:49 PDT 
Created attachment 209355 [details]
Patch
Comment 2 Early Warning System Bot 2013-08-22 06:24:07 PDT 
Comment on attachment 209355 [details]
Patch

Attachment 209355 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1545120
Comment 3 Early Warning System Bot 2013-08-22 06:27:23 PDT 
Comment on attachment 209355 [details]
Patch

Attachment 209355 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1384977
Comment 4 kov's GTK+ EWS bot 2013-08-22 06:36:38 PDT 
Comment on attachment 209355 [details]
Patch

Attachment 209355 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1424090
Comment 5 EFL EWS Bot 2013-08-22 06:47:43 PDT 
Comment on attachment 209355 [details]
Patch

Attachment 209355 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1492110
Comment 6 Andreas Kling 2013-08-22 08:08:30 PDT 
Created attachment 209368 [details]
Patch für landing
Comment 7 kov's GTK+ EWS bot 2013-08-22 08:19:35 PDT 
Comment on attachment 209368 [details]
Patch für landing

Attachment 209368 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1549103
Comment 8 Andreas Kling 2013-08-22 08:43:23 PDT 
Created attachment 209371 [details]
Patch för landing
Comment 9 Andreas Kling 2013-08-22 09:00:48 PDT 
Committed r154449: <http://trac.webkit.org/changeset/154449>
Comment 10 Csaba Osztrogonác 2013-08-22 09:41:51 PDT 
Comment on attachment 209371 [details]
Patch för landing

View in context: https://bugs.webkit.org/attachment.cgi?id=209371&action=review

> Source/WebCore/rendering/RenderWidget.cpp:122
> +    RenderObject::destroy();
> +#if 0
>      willBeDestroyed();
>  
>      // Grab the arena from node()->document()->renderArena() before clearing the node pointer.

It seems it made all tests assert: 

STDOUT: main frame - didStartProvisionalLoadForFrame
STDERR: ASSERTION FAILED: m_refCount <= 0
STDERR: /ramdisk/qt-linux-32-debug/build/Source/WebCore/rendering/RenderWidget.cpp(132) : virtual WebCore::RenderWidget::~RenderWidget()
Comment 11 Andreas Kling 2013-08-22 09:45:13 PDT 
(In reply to comment #10)
> (From update of attachment 209371 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209371&action=review
> 
> > Source/WebCore/rendering/RenderWidget.cpp:122
> > +    RenderObject::destroy();
> > +#if 0
> >      willBeDestroyed();
> >  
> >      // Grab the arena from node()->document()->renderArena() before clearing the node pointer.
> 
> It seems it made all tests assert: 
> 
> STDOUT: main frame - didStartProvisionalLoadForFrame
> STDERR: ASSERTION FAILED: m_refCount <= 0
> STDERR: /ramdisk/qt-linux-32-debug/build/Source/WebCore/rendering/RenderWidget.cpp(132) : virtual WebCore::RenderWidget::~RenderWidget()

<https://trac.webkit.org/r154452>