Bug 120151 – [Qt] DRT bug revealed/caused by r154300

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

After https://trac.webkit.org/changeset/154300 all dumpastext test started 
to fail on Qt WK1 and made Qt WK1 testers exit early after 500 failures.

See https://bugs.webkit.org/show_bug.cgi?id=119995#c14 and 
https://bugs.webkit.org/show_bug.cgi?id=119995#c15 for details.

(Just a note: I'm not working on Qt long time ago, so I can't 
and won't try to fix this bug. I just reported it by courtesy.)

But it would be great to fix it if you want greater test coverage than 0% 
for QtWebKit WK1. The bots can't catch any new regression come from JSC, 
WebCore, ... from r154300. (Now r154437 is the latest revision.)

[Allan Sandfeld Jensen]

It seems that QtInstance never had a getOwnPropertyDescriptor implementation but had a getOwnPropertySlot implementation. This means the behavior of getOwnPropertyDescriptor changed after it got implemented using getOwnPropertySlot.

[Allan Sandfeld Jensen]

Created attachment 209348 [details]
Patch

[WebKit Commit Bot]

Attachment 209348 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp']" exit_code: 1
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:776:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Allan Sandfeld Jensen]

Committed r154444: <http://trac.webkit.org/changeset/154444>