Bug 120122 – Treat elements with editable text roles as text controls

• Component: Accessibility
• Status: RESOLVED INVALID

[Roger Fong]

Assign elements with static text roles to ROLE_SYSTEM_TEXT.
Static text should still be accessible by AccessibleText which requires ROLE_SYSTEM_TEXT.
Accordingly, elements with static text roles should be treated as textControls.

[Radar WebKit Bug Importer]

<rdar://problem/14797439>

[Roger Fong]

Created attachment 209416 [details]
patch

[Roger Fong]

I'm not sure I've covered the full extent of what needs to be considered a text role but I think I've hit the big ones.

[Build Bot]

Comment on attachment 209416 [details]
patch

Attachment 209416 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1526497

New failing tests:
platform/mac/accessibility/internal-link-anchors.html
platform/mac/accessibility/bounds-for-range.html
platform/mac/accessibility/search-predicate.html

[Build Bot]

Created attachment 209423 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 209416 [details]
patch

Attachment 209416 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1546149

New failing tests:
platform/mac/accessibility/internal-link-anchors.html
platform/mac/accessibility/bounds-for-range.html

[Build Bot]

Created attachment 209428 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[chris fleizach]

Comment on attachment 209416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209416&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:286
> +    case StaticTextRole:

static text should not be marked as text control. Text control is only for things that allow text input

> Source/WebCore/accessibility/AccessibilityObject.cpp:287
> +    case EditableTextRole:

what's the difference between EditableTextRole and TextField or TextArea? can one of those roles be used instead of EditableTextRole?

[Roger Fong]

*(In reply to comment #8)
> (From update of attachment 209416 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209416&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:286
> > +    case StaticTextRole:
> 
> static text should not be marked as text control. Text control is only for things that allow text input

Ah, I did not see the isStaticText() method on accessibility object. I will use that in conjunction with isTextControl() when deciding whether or not to create my accessibility object.

> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:287
> > +    case EditableTextRole:
> 
> what's the difference between EditableTextRole and TextField or TextArea? can one of those roles be used instead of EditableTextRole?

You can have just a <div contenteditable=true>content here </div>
https://bugs.webkit.org/show_bug.cgi?id=120191 addresses this. (If it's a text node and content is editable it uses the EditableTextRole.

[Roger Fong]

I might need to split this up into 2, 1 line patches...
The two parts are actually not really related...

[Roger Fong]

Created attachment 209475 [details]
patch

Will likely cause some tests to need rebaselining.
I'll let EWS figure out which ones.

[Roger Fong]

No longer necessary since I'm fixing https://bugs.webkit.org/show_bug.cgi?id=120191 in a different way.

[Brent Fulgham]

Comment on attachment 209475 [details]
patch

Clear flag to remove from queue.