Bug 120092

Summary: [Windows] Refactor WebFrame to compose with WebFrameLoaderClient (rather than subclass)
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bfulgham, kling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 119964, 120323    
Attachments:
Description Flags
Patch andersca: review+

Description Brent Fulgham 2013-08-20 14:50:35 PDT 
Implementing the changes for Bug 119964 under Windows is difficult, because the WebFrame class is a subclass of WebFrameloaderClient. This makes it difficult to move the creation of the WebFrame to a separate step in the loading process, because Windows expects this object to already exist at the time the loading operations are done.

To make this a little easier, this first patch will refactor WebFrame to be more like the other ports by moving the WebFrameLoaderClient logic out of WebFrame, and simply having WebFrame use a loader object to do the work.
Comment 1 Brent Fulgham 2013-08-23 11:43:39 PDT 
Created attachment 209481 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-08-23 11:44:58 PDT 
<rdar://problem/14821436>
Comment 3 Anders Carlsson 2013-08-23 11:50:55 PDT 
Comment on attachment 209481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209481&action=review

> Source/WebKit/win/WebFramePolicyListener.cpp:125
> +        static_cast<WebFrameLoaderClient*>(&frame->loader().client())->receivedPolicyDecision(action);

I think you can just cast to WebFrameLoaderClient& here.

> Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h:205
> +    WebFramePolicyListenerPrivate* m_policyListenerPrivate;

I think this can be an OwnPtr.
Comment 4 Brent Fulgham 2013-08-23 12:30:26 PDT 
Committed r154508: <http://trac.webkit.org/changeset/154508>