[Windows] Report better error messages when WinLauncher/DRT Fail to Run

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

WinLauncher, DumpRenderTree, and other command-line utilities consist of a simple loader program and a payload DLL that contains the actual program logic.  In some cases, users cannot access the payload. A generic "Unable to load DLL" error message is presented to the user, and the program ends.

To help remote debugging and to get better information from our test system, we should query the error status from Windows and include a human-readable version of the message for the user.

This patch adds this additional diagnostic information to the launch code paths.

[Brent Fulgham]

Created attachment 209232 [details]
Patch

[Tim Horton]

Comment on attachment 209232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209232&action=review

> Tools/win/DLLLauncher/DLLLauncherMain.cpp:177
> +        return fatalError(L"Unknown Program", L"Failed to determine name of executabl: " + getLastErrorString(::GetLastError()));

you lost a useful e here

[Brent Fulgham]

Comment on attachment 209232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209232&action=review

>> Tools/win/DLLLauncher/DLLLauncherMain.cpp:177
>> +        return fatalError(L"Unknown Program", L"Failed to determine name of executabl: " + getLastErrorString(::GetLastError()));
> 
> you lost a useful e here

Whoops!

[Brent Fulgham]

Committed r154367: <http://trac.webkit.org/changeset/154367>