Bug 120083
Summary: | fast/js/regress/emscripten-cube2hash is failing on all the Mac bots | ||
---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> |
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | fpizlo, ggaren, mhahnenberg, rniwa, thorton |
Priority: | P2 | Keywords: | LayoutTestFailure |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Tim Horton
The test (fast/js/regress/emscripten-cube2hash) added by https://bugs.webkit.org/show_bug.cgi?id=120033 seems to be failing on the ML testers, with console.logs and exceptions and stuff:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r154351%20(10956)/fast/js/regress/emscripten-cube2hash-pretty-diff.html
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r154351%20(12124)/fast/js/regress/emscripten-cube2hash-pretty-diff.html
--- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/fast/js/regress/emscripten-cube2hash-expected.txt
+++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/fast/js/regress/emscripten-cube2hash-actual.txt
@@ -1,10 +1,13 @@
+CONSOLE MESSAGE: line 108: preload time: 4 ms
+CONSOLE MESSAGE: line 105: hash value: 892BDB6FD3F62E863D63DA55851700FDE3ACF30204798CE9
+CONSOLE MESSAGE: line 8579: Error: bad result:
JSRegress/emscripten-cube2hash
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS no exception thrown
-PASS successfullyParsed is true
+FAIL caught exception: Error: bad result:
+FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
TEST COMPLETE
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Filip Pizlo
Oh, yeah. I forgot to make the test do the right things for ENVIRONMENT_IS_WEB.
It's weird that the test doesn't fail on other configurations.
Tim Horton
(In reply to comment #1)
> Oh, yeah. I forgot to make the test do the right things for ENVIRONMENT_IS_WEB.
>
> It's weird that the test doesn't fail on other configurations.
I’d not be surprised if it did, I just haven’t looked and didn’t want to overstate.
Tim Horton
Failing test expectation in http://trac.webkit.org/changeset/154357
Filip Pizlo
Landed fix in http://trac.webkit.org/changeset/154377.