Bug 120078

Summary: Replace NodeRenderingContext with RenderStyle& as rendererIsNeeded() argument
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 120094    
Bug Blocks:    
Attachments:
Description Flags
patch darin: review+

Antti Koivisto
Reported 2013-08-20 12:45:01 PDT
Simplify.
Attachments
patch (53.29 KB, patch)
2013-08-20 12:51 PDT, Antti Koivisto 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-20 12:51:11 PDT
Created attachment 209219 [details] patch
Darin Adler
Comment 2 2013-08-20 14:10:35 PDT
Comment on attachment 209219 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=209219&action=review > Source/WebCore/html/HTMLMediaElement.cpp:558 > + return controls() ? HTMLElement::rendererIsNeeded(style) : false; I like && better than ? : for cases like this.
Antti Koivisto
Comment 3 2013-08-20 14:27:06 PDT
https://trac.webkit.org/r154358
WebKit Commit Bot
Comment 4 2013-08-20 15:09:19 PDT
Re-opened since this is blocked by bug 120094
Antti Koivisto
Comment 5 2013-08-20 16:01:20 PDT
The bot is wrong.
Daniel Bates
Comment 6 2013-09-16 11:27:21 PDT
(In reply to comment #3) > https://trac.webkit.org/r154358 Substituted "style" for "context" in the call to UNUSED_PARAM() in HTMLMediaElement::rendererIsNeeded() to fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit, and committed this change in <http://trac.webkit.org/changeset/155887>.
Note You need to log in before you can comment on or make changes to this bug.