Bug 120078

Summary: Replace NodeRenderingContext with RenderStyle& as rendererIsNeeded() argument
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 120094    
Bug Blocks:    
Attachments:
Description Flags
patch darin: review+

Description Antti Koivisto 2013-08-20 12:45:01 PDT 
Simplify.
Comment 1 Antti Koivisto 2013-08-20 12:51:11 PDT 
Created attachment 209219 [details]
patch
Comment 2 Darin Adler 2013-08-20 14:10:35 PDT 
Comment on attachment 209219 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209219&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:558
> +    return controls() ? HTMLElement::rendererIsNeeded(style) : false;

I like && better than ? : for cases like this.
Comment 3 Antti Koivisto 2013-08-20 14:27:06 PDT 
https://trac.webkit.org/r154358
Comment 4 WebKit Commit Bot 2013-08-20 15:09:19 PDT 
Re-opened since this is blocked by bug 120094
Comment 5 Antti Koivisto 2013-08-20 16:01:20 PDT 
The bot is wrong.
Comment 6 Daniel Bates 2013-09-16 11:27:21 PDT 
(In reply to comment #3)
> https://trac.webkit.org/r154358

Substituted "style" for "context" in the call to UNUSED_PARAM() in HTMLMediaElement::rendererIsNeeded() to fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit, and committed this change in <http://trac.webkit.org/changeset/155887>.