Bug 120076

Summary: remove more obj32 directory references
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch
none
Patch bfulgham: review+

Alex Christensen
Reported 2013-08-20 11:44:57 PDT
After https://bugs.webkit.org/show_bug.cgi?id=119512 there are still many places where obj32, lib32, and bin32 are hard-coded into scripts. These should all be replaced by the PlatformArchitecture macro. I still haven't done this everywhere, but this represents a step in the right direction.
Attachments
Patch (10.37 KB, patch)
2013-08-20 11:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.35 KB, patch)
2013-08-20 12:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.29 KB, patch)
2013-08-20 13:01 PDT, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-08-20 11:55:18 PDT
Created attachment 209214 [details] Patch
Alex Christensen
Comment 2 2013-08-20 11:56:46 PDT
This builds completely, runs, and doesn't seem to break anything.
Alex Christensen
Comment 3 2013-08-20 12:00:14 PDT
Created attachment 209217 [details] Patch
Alex Christensen
Comment 4 2013-08-20 13:01:56 PDT
Created attachment 209221 [details] Patch
Brent Fulgham
Comment 5 2013-08-20 13:22:22 PDT
Comment on attachment 209221 [details] Patch Nice! r=mw
Alex Christensen
Comment 6 2013-08-20 13:44:31 PDT
r154354
Note You need to log in before you can comment on or make changes to this bug.