Bug 120034

Summary: Remove custom getOwnPropertyDescriptor for global objects
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix ggaren: review+

Description Gavin Barraclough 2013-08-19 16:14:46 PDT 
Fix attributes of JSC SynbolTableObject entries, ensure that cross frame access is safe, and suppress prototype chain walk.
Comment 1 Gavin Barraclough 2013-08-19 16:21:06 PDT 
Created attachment 209137 [details]
Fix
Comment 2 WebKit Commit Bot 2013-08-19 16:23:15 PDT 
Attachment 209137 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSSymbolTableObject.h', u'Source/JavaScriptCore/runtime/PropertyDescriptor.h', u'Source/JavaScriptCore/runtime/PropertySlot.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp']" exit_code: 1
Source/JavaScriptCore/runtime/PropertyDescriptor.h:94:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2013-08-19 17:30:29 PDT 
Comment on attachment 209137 [details]
Fix

r=me
Comment 4 Gavin Barraclough 2013-08-19 22:46:13 PDT 
Committed revision 154313.