Bug 119992 – [Cairo] Canvas putImageData is not working as expected

• Component: Canvas
• Status: RESOLVED FIXED

[Hurnjoo Lee]

ImageBufferCairo::putImageArray didn't perform pre-multiply in case of zero alpha value.
If the alpha value is not 255, image data should always be pre-multiplied.

[Hurnjoo Lee]

Created attachment 209049 [details]
patch

[WebKit Commit Bot]

Attachment 209049 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/canvas-putImageData-zero-alpha-expected.txt', u'LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html', u'LayoutTests/platform/efl/fast/canvas/canvas-putImageData-zero-alpha-expected.png', u'LayoutTests/platform/gtk/fast/canvas/canvas-putImageData-zero-alpha-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp']" exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hurnjoo Lee]

Created attachment 209050 [details]
fixed patch

[Hurnjoo Lee]

I'm sorry, there was some mistake.
I will upload patch again.

[Hurnjoo Lee]

Created attachment 209055 [details]
Fixed patch v2

[Chris Dumez]

Comment on attachment 209055 [details]
Fixed patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=209055&action=review

> LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:6
> +    background-color:blue;

Can this be a ref test instead?

> LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:33
> +      if (window.testRunner) {

No need for curly brackets here.

[Hurnjoo Lee]

Created attachment 209060 [details]
fixed patch v3

[Hurnjoo Lee]

(In reply to comment #6)

Thanks for the review.

> (From update of attachment 209055 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209055&action=review
> 
> > LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:6
> > +    background-color:blue;
> 
> Can this be a ref test instead?

Done. I added the ref test.

> 
> > LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:33
> > +      if (window.testRunner) {
> 
> No need for curly brackets here.

Done.

[Martin Robinson]

(In reply to comment #8)
> (In reply to comment #6)
> 
> Thanks for the review.

Looks good to me, assuming this is how other ports work.

[Hurnjoo Lee]

Created attachment 209148 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 209148 [details]
patch for landing

Clearing flags on attachment: 209148

Committed r154316: <http://trac.webkit.org/changeset/154316>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.