Summary: | [Cairo] Canvas putImageData is not working as expected | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hurnjoo Lee <hurnjoo.lee> | ||||||||||||
Component: | Canvas | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, d-r, gyuyoung.kim, mrobinson, rakuco | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Hurnjoo Lee
2013-08-18 21:24:57 PDT
Created attachment 209049 [details]
patch
Attachment 209049 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/canvas/canvas-putImageData-zero-alpha-expected.txt', u'LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html', u'LayoutTests/platform/efl/fast/canvas/canvas-putImageData-zero-alpha-expected.png', u'LayoutTests/platform/gtk/fast/canvas/canvas-putImageData-zero-alpha-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp']" exit_code: 1
LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 209050 [details]
fixed patch
I'm sorry, there was some mistake. I will upload patch again. Created attachment 209055 [details]
Fixed patch v2
Comment on attachment 209055 [details] Fixed patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=209055&action=review > LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:6 > + background-color:blue; Can this be a ref test instead? > LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:33 > + if (window.testRunner) { No need for curly brackets here. Created attachment 209060 [details]
fixed patch v3
(In reply to comment #6) Thanks for the review. > (From update of attachment 209055 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209055&action=review > > > LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:6 > > + background-color:blue; > > Can this be a ref test instead? Done. I added the ref test. > > > LayoutTests/fast/canvas/canvas-putImageData-zero-alpha.html:33 > > + if (window.testRunner) { > > No need for curly brackets here. Done. (In reply to comment #8) > (In reply to comment #6) > > Thanks for the review. Looks good to me, assuming this is how other ports work. Created attachment 209148 [details]
patch for landing
Comment on attachment 209148 [details] patch for landing Clearing flags on attachment: 209148 Committed r154316: <http://trac.webkit.org/changeset/154316> All reviewed patches have been landed. Closing bug. |