Bug 119959 – Add TextNodeTraversal

• Component: DOM
• Status: RESOLVED FIXED

[Antti Koivisto]

Better traversal for text nodes.

[Antti Koivisto]

Created attachment 209005 [details]
patch

[Andreas Kling]

Comment on attachment 209005 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209005&action=review

r=me

> Source/WebCore/dom/Text.cpp:139
> +        resultLength += text->data().length();

text->length() here would avoid some String ref churn.

> Source/WebCore/dom/TextNodeTraversal.h:68
> +    // Except for the root containers, only elements can have element children.

Copypasta detected.

> Source/WebCore/dom/TextNodeTraversal.h:80
> +    // Except for the root containers, only elements can have element children.

Copypasta detected.

> Source/WebCore/editing/ApplyStyleCommand.cpp:1525
>      Vector<RefPtr<Text> > textNodes;

Might as well >> this one too. It's so close!

[Build Bot]

Comment on attachment 209005 [details]
patch

Attachment 209005 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1387363

New failing tests:
fast/dom/Text/replaceWholeText.html

[Build Bot]

Created attachment 209008 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Antti Koivisto]

http://trac.webkit.org/changeset/154240 (with a bug fix)