Bug 119936

Summary: Fix some encapsulation issues of RuleSet
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: CSSAssignee: Benjamin Poulain <benjamin>
Severity: Normal CC: allan.jensen, commit-queue, darin, esprehn+autocc, glenn, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch darin: review+

Description Benjamin Poulain 2013-08-16 22:47:06 PDT
Fix some encapsulation issues of RuleSet
Comment 1 Benjamin Poulain 2013-08-16 22:52:50 PDT
Created attachment 208979 [details]
Comment 2 Darin Adler 2013-08-17 05:13:48 PDT
Comment on attachment 208979 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=208979&action=review

> Source/WebCore/css/RuleSet.h:111
> +        RuleSetSelectorPair(const RuleSetSelectorPair& rs) : selector(rs.selector), ruleSet(const_cast<RuleSetSelectorPair*>(&rs)->ruleSet.release()) { }

I think the word “pair” would be better than “rs” for this variable name.

I think it’s awkward to write this as a copy constructor instead of a move constructor.

Looks like you are just moving this code, though.
Comment 3 Benjamin Poulain 2013-08-19 14:42:07 PDT
Committed r154299: <http://trac.webkit.org/changeset/154299>