Bug 119931

Summary: ANGLE fails to build with trunk clang: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: ANGLEAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, ddkilzer, dino, kbr, kondapallykalyan, mrowe, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2013-08-16 21:12:45 PDT 
ANGLE fails to build with trunk clang.  Errors are due to the 'register' keyword being deprecated:

glslang_lex.cpp:2033:2: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
Tokenizer.cpp:788:2: error: 'register' storage class specifier is deprecated [-Werror,-Wdeprecated-register]
Comment 1 David Kilzer (:ddkilzer) 2013-08-16 21:13:15 PDT 
<rdar://problem/14763822>
Comment 2 David Kilzer (:ddkilzer) 2013-08-16 21:19:42 PDT 
Created attachment 208974 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2013-08-16 22:47:11 PDT 
Comment on attachment 208974 [details]
Patch v1

Removed r? status.  I'm not sure how this passed the EWS bots as it should have generated an error about an unknown pragma.
Comment 4 David Kilzer (:ddkilzer) 2013-08-16 23:28:39 PDT 
Created attachment 208980 [details]
Patch v2
Comment 5 Darin Adler 2013-08-17 05:14:45 PDT 
Comment on attachment 208980 [details]
Patch v2

Tempting to just get rid of all those "register", but I guess we want to make this easier to merge with future versions of ANGLE. Are you contributing this to the upstream ANGLE too?
Comment 6 WebKit Commit Bot 2013-08-17 05:37:43 PDT 
Comment on attachment 208980 [details]
Patch v2

Clearing flags on attachment: 208980

Committed r154223: <http://trac.webkit.org/changeset/154223>
Comment 7 WebKit Commit Bot 2013-08-17 05:37:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 David Kilzer (:ddkilzer) 2013-08-17 07:02:29 PDT 
(In reply to comment #5)
> (From update of attachment 208980 [details])
> Tempting to just get rid of all those "register", but I guess we want to make this easier to merge with future versions of ANGLE.

The bigger concern is that the 'register' keywords are in generated code from flex, so we really don't want to be in the business of remembering to modify the generated source code every time.

> Are you contributing this to the upstream ANGLE too?

Yes, insomuch as that's possible (which means I filed a bug and pointed it back here):
<http://code.google.com/p/angleproject/issues/detail?id=463>