Summary: | AX: WebKit is not exposing AXLanguage correctly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, jer.noble, mario, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
James Craig
2013-08-16 16:36:01 PDT
Created attachment 209097 [details]
patch
Comment on attachment 209097 [details]
patch
As you are an expert on the Cocoa accessibility interface, I’ll accept your implicit assertion here that AXLanguage with a value of empty string is a helpful result on these tests.
(In reply to comment #3) > (From update of attachment 209097 [details]) > As you are an expert on the Cocoa accessibility interface, I’ll accept your implicit assertion here that AXLanguage with a value of empty string is a helpful result on these tests. Yes this is what we want outputted here. We have tests that already specifically check for the value of this attribute. This patch just makes it so that the attribute shows up with the list of attributes are queried. It's mostly to aid usage of the AX inspector, and does not impact VoiceOver This commit caused test failures (in accessibility/lists.h) on numerous Mac bots: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r154286%20(9534)/results.html http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r154286%20(11777)/results.html http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r154285%20(10217)/results.html http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r154286%20(10865)/results.html Rebaselined platform/mac/accessibility/lists-expected.txt in <https://trac.webkit.org/r154292>. (In reply to comment #7) > Rebaselined platform/mac/accessibility/lists-expected.txt in <https://trac.webkit.org/r154292>. Thanks Jer. I was running on 10.9 and missed this switch |