Bug 119884

Summary: [GTK] fixing localizedString method name
Product: WebKit Reporter: Danilo de Paula <danilo.eu>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Danilo de Paula
Reported 2013-08-16 02:26:24 PDT
[GTK] fixing localizedString method name
Attachments
Patch (1.42 KB, patch)
2013-08-16 02:26 PDT, Danilo de Paula 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2013-08-16 02:29 PDT, Danilo de Paula 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Danilo de Paula
Comment 1 2013-08-16 02:26:47 PDT
Created attachment 208896 [details] Patch
Danilo de Paula
Comment 2 2013-08-16 02:27:35 PDT
The method name defined in LocalizedStringsGtk.cpp doesn't not match the one declared in LocalizedStrings.h
WebKit Commit Bot
Comment 3 2013-08-16 02:28:14 PDT
Attachment 208896 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Danilo de Paula
Comment 4 2013-08-16 02:29:32 PDT
Created attachment 208897 [details] Patch
WebKit Commit Bot
Comment 5 2013-08-16 04:49:47 PDT
Comment on attachment 208897 [details] Patch Clearing flags on attachment: 208897 Committed r154175: <http://trac.webkit.org/changeset/154175>
WebKit Commit Bot
Comment 6 2013-08-16 04:49:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.