Summary: | [sh4] Fix sh4 build after r154156 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ggaren, mark.lam, msaboff, oliver | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Julien Brianceau
2013-08-16 00:15:38 PDT
Created attachment 208886 [details]
sh4 build fix
Comment on attachment 208886 [details] sh4 build fix View in context: https://bugs.webkit.org/attachment.cgi?id=208886&action=review > Source/JavaScriptCore/jit/JITStubsSH4.h:120 > - "lds r1, pr" "\n" > - "rts" "\n" > + "jmp @r1" "\n" This part isn't due to r154156. Why is this necessary? (In reply to comment #2) > (From update of attachment 208886 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208886&action=review > > > Source/JavaScriptCore/jit/JITStubsSH4.h:120 > > - "lds r1, pr" "\n" > > - "rts" "\n" > > + "jmp @r1" "\n" > > This part isn't due to r154156. Why is this necessary? It saves one useless opcode, but you're right, this is not linked to r154156. Do you want me to provide 2 separate patches ? Created attachment 208891 [details]
sh4 build fix
Build fix only
Created attachment 208893 [details]
sh4 build fix (with description in ChangeLog)
Comment on attachment 208893 [details] sh4 build fix (with description in ChangeLog) Clearing flags on attachment: 208893 Committed r154170: <http://trac.webkit.org/changeset/154170> All reviewed patches have been landed. Closing bug. |