Bug 119871

Summary:

Flash of garbage pixels when playing a show on Hulu

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Simon Fraser (smfr) 2013-08-15 15:28:41 PDT

Flash of garbage pixels when playing a show on Hulu

Comment 1 Simon Fraser (smfr) 2013-08-15 15:29:25 PDT

<rdar://problem/14307781>

Comment 2 Simon Fraser (smfr) 2013-08-15 15:37:32 PDT

Created attachment 208866 [details]
Patch

Comment 3 Tim Horton 2013-08-15 15:40:09 PDT

Comment on attachment 208866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208866&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:780
> +        layer->setViewportConstrainedNotCompositedReason(RenderLayer::NoNotCompositedReason);

The code above only resets this if it's already set to not composited, and sets layerChanged (which gets returned). Does that matter? Should we do it here too?

Comment 4 Simon Fraser (smfr) 2013-08-15 16:17:27 PDT

We don't need to set layerChanged .
http://trac.webkit.org/changeset/154147