Summary: | [CSS Shapes] Remove extraneous window.internals calls in layout tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bear Travis <betravis> | ||||
Component: | CSS | Assignee: | Bear Travis <betravis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, WebkitBugTracker | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 89256 | ||||||
Attachments: |
|
Description
Bear Travis
2013-08-15 14:23:33 PDT
Created attachment 208856 [details]
Initial patch
Comment on attachment 208856 [details]
Initial patch
Can we wait on this change until most platforms are shipping this feature by default? What’s the rush?
This patch is just cleanup, as the window.internals.settings.setCSSShapesEnabled calls in these tests are unnecessary. The platforms that expose setCSSShapesEnabled now have shapes enabled by default, and the platforms that don't exclude these test directories. window.internals.settings.setCSSShapesEnabled(true) is basically a no-op. These tests would fail with or without this patch in builds that do not compile with ENABLE_CSS_SHAPES flag set. Comment on attachment 208856 [details]
Initial patch
r=me
Comment on attachment 208856 [details] Initial patch Clearing flags on attachment: 208856 Committed r154500: <http://trac.webkit.org/changeset/154500> All reviewed patches have been landed. Closing bug. |