|Summary:||[CSS Shapes] Remove extraneous window.internals calls in layout tests|
|Product:||WebKit||Reporter:||Bear Travis <betravis>|
|Component:||CSS||Assignee:||Bear Travis <betravis>|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
Description Bear Travis 2013-08-15 14:23:33 PDT
With CSS Shapes enabled by default in nightly builds, we no longer have to explicitly enable CSS Shapes for each test.
Comment 2 Darin Adler 2013-08-15 18:27:11 PDT
Comment on attachment 208856 [details] Initial patch Can we wait on this change until most platforms are shipping this feature by default? What’s the rush?
Comment 3 Bear Travis 2013-08-16 10:29:16 PDT
This patch is just cleanup, as the window.internals.settings.setCSSShapesEnabled calls in these tests are unnecessary. The platforms that expose setCSSShapesEnabled now have shapes enabled by default, and the platforms that don't exclude these test directories. window.internals.settings.setCSSShapesEnabled(true) is basically a no-op. These tests would fail with or without this patch in builds that do not compile with ENABLE_CSS_SHAPES flag set.
Comment 4 Alexandru Chiculita 2013-08-23 10:46:49 PDT
Comment on attachment 208856 [details] Initial patch r=me
Comment 5 WebKit Commit Bot 2013-08-23 11:09:29 PDT
Comment on attachment 208856 [details] Initial patch Clearing flags on attachment: 208856 Committed r154500: <http://trac.webkit.org/changeset/154500>
Comment 6 WebKit Commit Bot 2013-08-23 11:09:31 PDT
All reviewed patches have been landed. Closing bug.