Summary: | [WK2] NetworkProcess should use a temporary storage session for tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rniwa | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2013-08-15 11:52:18 PDT
Created attachment 208834 [details]
proposed patch
Comment on attachment 208834 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=208834&action=review > Source/WebKit2/UIProcess/WebContext.cpp:1083 > +void WebContext::useTestingNetworkSession() > +{ > + ASSERT(m_processes.isEmpty()); > +#if ENABLE(NETWORK_PROCESS) > + ASSERT(!m_networkProcess); > +#endif > + > + m_useTestingNetworkSession = true; > +} Would be nice to do nothing if called incorrectly. Silently in release builds, after the assertion in debug builds. > Source/WebKit2/UIProcess/WebContext.h:470 > + bool m_useTestingNetworkSession; I would name this m_shouldUseTestingNetworkSession or m_usesTestingNetworkSession. The way it’s named here sounds like a verb phrase, not an adjective phrase. This patch appears to have broken http/tests/navigation/post-frames-goback1.html on WK2 builders: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r154201%20(10857)/results.html http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fnavigation%2Fpost-frames-goback1.html |