Bug 119855 – [WK2] NetworkProcess should use a temporary storage session for tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

Both DumpRenderTree and single WebProcess WebKitTestRunner switch loader to a private testing session to avoid interfering with regular browsing storage, or leaking information between runs.

We should do this for NetworkProcess, too.

[Alexey Proskuryakov]

Created attachment 208834 [details]
proposed patch

[Darin Adler]

Comment on attachment 208834 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208834&action=review

> Source/WebKit2/UIProcess/WebContext.cpp:1083
> +void WebContext::useTestingNetworkSession()
> +{
> +    ASSERT(m_processes.isEmpty());
> +#if ENABLE(NETWORK_PROCESS)
> +    ASSERT(!m_networkProcess);
> +#endif
> +
> +    m_useTestingNetworkSession = true;
> +}

Would be nice to do nothing if called incorrectly. Silently in release builds, after the assertion in debug builds.

> Source/WebKit2/UIProcess/WebContext.h:470
> +    bool m_useTestingNetworkSession;

I would name this m_shouldUseTestingNetworkSession or m_usesTestingNetworkSession. The way it’s named here sounds like a verb phrase, not an adjective phrase.

[Alexey Proskuryakov]

Committed r154144 with proposed changes.

[Ryosuke Niwa]

This patch appears to have broken http/tests/navigation/post-frames-goback1.html on WK2 builders:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r154201%20(10857)/results.html

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fnavigation%2Fpost-frames-goback1.html