Bug 119852

Summary:

Frame::scriptController() should return a reference

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

WebCore Misc.

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eflews.bot, gyuyoung.kim, kling, psolanki, webkit-ews

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch 1	none
Patch 2 - with potential qt fix	none
Patch 3 - for review and landing	kling: review+, eflews.bot: commit-queue-

Pratik Solanki

Reported 2013-08-15 11:35:45 PDT

m_script is never null so we can just return a reference.

Attachments
Patch 1 (100.88 KB, patch) 2013-08-15 11:47 PDT, Pratik Solanki	no flags	Details Formatted Diff Diff
Patch 2 - with potential qt fix (102.28 KB, patch) 2013-08-15 13:40 PDT, Pratik Solanki	no flags	Details Formatted Diff Diff
Patch 3 - for review and landing (111.86 KB, patch) 2013-08-15 16:46 PDT, Pratik Solanki	kling: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Pratik Solanki

Comment 1 2013-08-15 11:47:49 PDT

Created attachment 208830 [details] Patch 1

Early Warning System Bot

Comment 2 2013-08-15 12:00:28 PDT

Comment on attachment 208830 [details] Patch 1 Attachment 208830 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1467297

Early Warning System Bot

Comment 3 2013-08-15 12:05:26 PDT

Comment on attachment 208830 [details] Patch 1 Attachment 208830 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1466361

EFL EWS Bot

Comment 4 2013-08-15 12:27:40 PDT

Comment on attachment 208830 [details] Patch 1 Attachment 208830 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1469272

Pratik Solanki

Comment 5 2013-08-15 13:40:37 PDT

Created attachment 208845 [details] Patch 2 - with potential qt fix

EFL EWS Bot

Comment 6 2013-08-15 14:25:30 PDT

Comment on attachment 208845 [details] Patch 2 - with potential qt fix Attachment 208845 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1471247

Pratik Solanki

Comment 7 2013-08-15 16:46:10 PDT

Created attachment 208869 [details] Patch 3 - for review and landing

Andreas Kling

Comment 8 2013-08-15 16:48:58 PDT

Comment on attachment 208869 [details] Patch 3 - for review and landing LGTM, assuming it builds everywhere!

Pratik Solanki

Comment 9 2013-08-15 17:17:48 PDT

(In reply to comment #8) > (From update of attachment 208869 [details]) > LGTM, assuming it builds everywhere! Thanks. The previous failure on efl was not due to my patch. But I'll land this later tonight when I can monitor the bots.

EFL EWS Bot

Comment 10 2013-08-15 19:36:42 PDT

Comment on attachment 208869 [details] Patch 3 - for review and landing Attachment 208869 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1473300

Pratik Solanki

Comment 11 2013-08-16 10:54:41 PDT

Committed r154192: <http://trac.webkit.org/changeset/154192>

Note You need to log in before you can comment on or make changes to this bug.