Summary: | Frame::scriptController() should return a reference | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||||||
Component: | WebCore Misc. | Assignee: | Pratik Solanki <psolanki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eflews.bot, gyuyoung.kim, kling, psolanki, webkit-ews | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Pratik Solanki
2013-08-15 11:35:45 PDT
Created attachment 208830 [details]
Patch 1
Comment on attachment 208830 [details] Patch 1 Attachment 208830 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1467297 Comment on attachment 208830 [details] Patch 1 Attachment 208830 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1466361 Comment on attachment 208830 [details] Patch 1 Attachment 208830 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1469272 Created attachment 208845 [details]
Patch 2 - with potential qt fix
Comment on attachment 208845 [details] Patch 2 - with potential qt fix Attachment 208845 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1471247 Created attachment 208869 [details]
Patch 3 - for review and landing
Comment on attachment 208869 [details]
Patch 3 - for review and landing
LGTM, assuming it builds everywhere!
(In reply to comment #8) > (From update of attachment 208869 [details]) > LGTM, assuming it builds everywhere! Thanks. The previous failure on efl was not due to my patch. But I'll land this later tonight when I can monitor the bots. Comment on attachment 208869 [details] Patch 3 - for review and landing Attachment 208869 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1473300 Committed r154192: <http://trac.webkit.org/changeset/154192> |