Bug 119846

Summary:

[Qt] Do not check specifically for version 5.0

Product:

WebKit

Reporter:

Allan Sandfeld Jensen <allan.jensen>

Component:

Tools / Tests

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dpranke, glenn, jturcotte

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jturcotte: review+

Description Allan Sandfeld Jensen 2013-08-15 09:17:00 PDT

We currently check for Qt version 5.0 before using the WK1 and WK2 specific layout results. This needs to made generic so it also works on Qt 5.1 and Qt 5.2.

The directory names should also be renamed, but removing the version check is probably a better first step.

Comment 1 Allan Sandfeld Jensen 2013-08-15 09:18:58 PDT

Created attachment 208814 [details]
Patch

Comment 2 Jocelyn Turcotte 2013-08-15 09:32:40 PDT

Comment on attachment 208814 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208814&action=review

> Tools/Scripts/webkitpy/port/qt.py:125
> +        #           qt-5.x

That comment should probably follow the code, it's still named qt-5.0.

Comment 3 Allan Sandfeld Jensen 2013-08-15 09:52:18 PDT

Committed r154107: <http://trac.webkit.org/changeset/154107>