Bug 119835

Summary: Disable maybe-uninitialized warning with GCC 4.8
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: JavaScriptCoreAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Allan Sandfeld Jensen
Reported 2013-08-15 05:10:00 PDT
GCC 4.8 emits a maybe-uninitialized warning for UnlinkedCodeBlock.cpp:249. It seems to be a mistake from GCC, but we might as well fix it to shut it up.
Attachments
Patch (1.50 KB, patch)
2013-08-15 05:12 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.16 KB, patch)
2013-08-20 03:47 PDT, Allan Sandfeld Jensen 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-08-15 05:12:03 PDT
Created attachment 208802 [details] Patch
Anders Carlsson
Comment 2 2013-08-15 16:24:32 PDT
Comment on attachment 208802 [details] Patch I hate the “may be uninitialized” warning; it uses the GCC optimizer and can thus give different results based on the optimization level. I suggest you turn this warning off instead.
Allan Sandfeld Jensen
Comment 3 2013-08-20 03:47:15 PDT
Created attachment 209179 [details] Patch Disable the warning instead.
Anders Carlsson
Comment 4 2013-08-20 07:39:30 PDT
Comment on attachment 209179 [details] Patch Looks good, but please retitle the bug as well.
Allan Sandfeld Jensen
Comment 5 2013-08-21 02:23:06 PDT
Committed r154381: <http://trac.webkit.org/changeset/154381>
Note You need to log in before you can comment on or make changes to this bug.