Bug 119822

Summary: [Windows] DumpRenderTree is not using the same preferences as the Mac build.
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch thorton: review+

Brent Fulgham
Reported 2013-08-14 15:54:23 PDT
We should be consistent in our DRT test settings between the Mac and Windows ports, at least where such options exist. This patch adds some missing preferences to the Windows DRT setup.
Attachments
Patch (4.39 KB, patch)
2013-08-14 16:58 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (4.10 KB, patch)
2013-08-16 11:48 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.93 KB, patch)
2013-08-16 11:51 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.83 KB, patch)
2013-08-16 12:05 PDT, Brent Fulgham 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-08-14 16:58:00 PDT
Created attachment 208773 [details] Patch
Brent Fulgham
Comment 2 2013-08-16 11:48:30 PDT
Created attachment 208939 [details] Patch
Brent Fulgham
Comment 3 2013-08-16 11:51:34 PDT
Created attachment 208940 [details] Patch
Brent Fulgham
Comment 4 2013-08-16 12:03:50 PDT
Using a dedicated CFRunLoop in DRT did not work as I expected, resulting in hanging at exit. This is because we reuse the WebView repeatedly to execute different tests, and the main message loop does not receive the expected WM_QUIT message used to terminate the runloop. Instead, we wait until the message queue is empty (since DRT is pumping messages into it manually), and use that to end the current test iteration. So, instead of letting CFRunLoopRun() handle processing, I reverted to the original manual message loop, and just call CFRunLoopRunInMode with a 0 argument to invoke one block/dispatch call before returning to process any Windows calls.
Brent Fulgham
Comment 5 2013-08-16 12:05:00 PDT
Created attachment 208942 [details] Patch
Brent Fulgham
Comment 6 2013-08-16 12:07:49 PDT
Committed r154198: <http://trac.webkit.org/changeset/154198>
Note You need to log in before you can comment on or make changes to this bug.