| Summary: | Finish making FloatingObject a real class with private members | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||
| Component: | New Bugs | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Bem Jones-Bey
2013-08-14 11:09:28 PDT
Created attachment 208747 [details]
Patch
Port patch from Blink
Does this additional encapsulation help with something forthcoming? It's the beginning of making floats easier to hack on and understand. There is also a goal of increasing security and performance of floats in general. (One pathalogical example the blink guys have been looking at is http://oilevent.com/, which causes very bad behavior in the placed floats tree, among other places) I'd also like to port the perf fixes they've been doing in this area. I also have patches that I've worked on that I'll be porting over as well. Comment on attachment 208747 [details]
Patch
Patch looks fine. The FIXME next to pagination strut is not necessary though. It should be a LayoutUnit actually.
Created attachment 208748 [details]
Patch
Update comment to reference LayoutUnit
Comment on attachment 208748 [details]
Patch
r=me
Comment on attachment 208748 [details] Patch Rejecting attachment 208748 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 00BC0EC4.sh" (1 failure) Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65 ** wait: No child processes. Stop. make: *** Waiting for unfinished jobs.... make: *** wait: No child processes. Stop. Command /bin/sh failed with exit code 2 ** BUILD FAILED ** The following build commands failed: PhaseScriptExecution "Generate Derived Sources" "/Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/Derived Sources.build/Script-C0CE72841247E66800BC0EC4.sh" (1 failure) Full output: http://webkit-queues.appspot.com/results/1466002 Comment on attachment 208748 [details]
Patch
That's a really strange failure, and I still build fine locally after syncing to head, so lets try the CQ one more time.
Comment on attachment 208748 [details] Patch Rejecting attachment 208748 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: " (1 failure) Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65 .sb make: *** wait: No child processes. Stop. make: *** Waiting for unfinished jobs.... make: *** wait: No child processes. Stop. Command /bin/sh failed with exit code 2 ** BUILD FAILED ** The following build commands failed: PhaseScriptExecution "Generate Derived Sources" "/Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/Derived Sources.build/Script-C0CE72841247E66800BC0EC4.sh" (1 failure) Full output: http://webkit-queues.appspot.com/results/1458815 (In reply to comment #9) > (From update of attachment 208748 [details]) > Rejecting attachment 208748 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > " > (1 failure) > > Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65 > .sb > make: *** wait: No child processes. Stop. > make: *** Waiting for unfinished jobs.... > make: *** wait: No child processes. Stop. > Command /bin/sh failed with exit code 2 > > > ** BUILD FAILED ** > > > The following build commands failed: > PhaseScriptExecution "Generate Derived Sources" "/Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/Derived Sources.build/Script-C0CE72841247E66800BC0EC4.sh" > (1 failure) > > Full output: http://webkit-queues.appspot.com/results/1458815 I've looked over this output a couple of times, and I can't see anything that would be caused by my patch. So I'm going to commit manually, since it passed all the EWS bots. Committed r154069: <http://trac.webkit.org/changeset/154069> |