Bug 119789

Summary:

Regression(r153770?): Several tests in fast/events/touch are crashing on EFL

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

cdumez, enmi.lee, lucas.de.marchi, mpakulavelrutka

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none

Ryuan Choi

Reported 2013-08-14 03:17:40 PDT

Maybe after r153770, several tests in fast/events/touch are crashed.

Attachments
proposed patch (6.35 KB, patch) 2014-10-02 03:13 PDT, Michal Pakula vel Rutka	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michal Pakula vel Rutka

Comment 1 2014-10-02 03:10:03 PDT

Some of layout tests send new touch start events after clearing touch points, without sending touch end or touch cancel events. This causes GestureRecognizer to incorrectly recognize event as multi-touch while having only one touch point passed in the event. While identifying events GestureRecognizer tries to access second touch point, going out of touch points array bounds leading to crash. The fix resets current event and starts recognizing touch start event from the beginning.

Michal Pakula vel Rutka

Comment 2 2014-10-02 03:13:39 PDT

Created attachment 239099 [details] proposed patch

Michael Catanzaro

Comment 3 2016-09-17 07:06:01 PDT

Comment on attachment 239099 [details] proposed patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

Note You need to log in before you can comment on or make changes to this bug.