Bug 119786

Summary: [EFL] decoration of search type is different from other platforms
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ryuan Choi 2013-08-14 00:25:23 PDT 
Search field has three types of decoration style, -webkit-search-results-button, -webkit-search-results-decoration and -webkit-search-decoration

Other platforms except Efl port draw glass icon for search type in first two cases,
but only Efl ports draw icon in last case.

It looks better for Efl port to draw icon in first two cases like other ports.
Comment 1 Ryuan Choi 2013-08-14 01:12:32 PDT 
Created attachment 208705 [details]
Patch
Comment 2 Gyuyoung Kim 2013-08-14 01:26:39 PDT 
Comment on attachment 208705 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208705&action=review

I made that the magnifying glass icon was always shown. I don't object to follow behavior of other ports. r=me.

> Source/WebCore/ChangeLog:7
> +        Other platforms except EFL port draw glass icon for

glass -> a magnifying glass ?

> Source/WebCore/ChangeLog:9
> +        but Efl port draw it for -webkit-search-decoration.

draws ?
Comment 3 Gyuyoung Kim 2013-08-14 01:49:00 PDT 
Comment on attachment 208705 [details]
Patch

I checked chrome also has same behavior as this patch's. Thanks.
Comment 4 Ryuan Choi 2013-08-14 22:13:09 PDT 
Committed r154089: <http://trac.webkit.org/changeset/154089>
Comment 5 Ryuan Choi 2013-08-14 22:25:26 PDT 
Comment on attachment 208705 [details]
Patch

landed after fixed changelog.

Thanks.