Bug 119775

Summary: [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Brent Fulgham
Reported 2013-08-13 16:52:26 PDT
It is impossible to adjust any of the debugging settings in WinLauncher without modifying the program and rebuilding. This bug adds a 'Debug' menu with a few important options for testing different WebKit features.
Attachments
Patch (11.51 KB, patch)
2013-08-14 08:50 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (12.21 KB, patch)
2013-08-14 10:29 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (13.08 KB, patch)
2013-08-14 10:47 PDT, Brent Fulgham 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-08-14 08:44:52 PDT
<rdar://problem/14735682>
Brent Fulgham
Comment 2 2013-08-14 08:50:31 PDT
Created attachment 208733 [details] Patch
Brent Fulgham
Comment 3 2013-08-14 10:29:28 PDT
Created attachment 208740 [details] Patch
Brent Fulgham
Comment 4 2013-08-14 10:47:25 PDT
Created attachment 208743 [details] Patch
Brent Fulgham
Comment 5 2013-08-14 12:26:11 PDT
I hit a bit of scope creep. I added: 1. Debug menu (a) Use AV Foundation (b) Use Accelerated Compositing (c) Enable WebKit Full Screen (d) Show Compositing Borders (e) Show Repaint Count 2. Develop Menu (a) Show Web Inspector (b) Disable Images (c) Disable Styles (d) Disable JavaScript (e) Disable Local File Restrictions 3. History Menu (a) Back (b) Forward I need to clean up the program and make the menus enable/disable based on whether history is present (etc), but this is a nice first step that lets us toggle these settings when exploring a problem.
Tim Horton
Comment 6 2013-08-14 12:35:00 PDT
Comment on attachment 208743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208743&action=review > Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:73 > + MENUITEM "Show Compositing Borders", IDM_COMPOSITING_BORDERS > + MENUITEM "Show Repaint Count", IDM_REPAINT_COUNT Safari has both of these as one option; they go together well.
Brent Fulgham
Comment 7 2013-08-14 13:36:57 PDT
(In reply to comment #6) > (From update of attachment 208743 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208743&action=review > > > Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:73 > > + MENUITEM "Show Compositing Borders", IDM_COMPOSITING_BORDERS > > + MENUITEM "Show Repaint Count", IDM_REPAINT_COUNT > > Safari has both of these as one option; they go together well. I'll fix that on landing. Thanks for the review!
Brent Fulgham
Comment 8 2013-08-14 13:42:31 PDT
Committed r154070: <http://trac.webkit.org/changeset/154070>
Note You need to log in before you can comment on or make changes to this bug.