Bug 119770

Summary:

Foo::s_info should be Foo::info(), so that you can change how the s_info is actually linked

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, barraclough, cdumez, commit-queue, dino, eric.carlson, ggaren, glenn, jer.noble, jsbell, kondapallykalyan, mark.lam, mhahnenberg, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

119064

Attachments:

Description	Flags
the patch	mhahnenberg: review+

Filip Pizlo

Reported 2013-08-13 14:35:14 PDT

Patch forthcoming.

Attachments
the patch (499.86 KB, patch) 2013-08-13 17:05 PDT, Filip Pizlo	mhahnenberg: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-08-13 17:05:54 PDT

Created attachment 208691 [details] the patch

WebKit Commit Bot

Comment 2 2013-08-13 17:08:42 PDT

Attachment 208691 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackConstructor.cpp', u'Source/JavaScriptCore/API/JSCallbackConstructor.h', u'Source/JavaScriptCore/API/JSCallbackFunction.cpp', u'Source/JavaScriptCore/API/JSCallbackFunction.h', u'Source/JavaScriptCore/API/JSCallbackObject.cpp', u'Source/JavaScriptCore/API/JSCallbackObject.h', u'Source/JavaScriptCore/API/JSCallbackObjectFunctions.h', u'Source/JavaScriptCore/API/JSObjectRef.cpp', u'Source/JavaScriptCore/API/JSValueRef.cpp', u'Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.cpp', u'Source/JavaScriptCore/API/ObjCCallbackFunction.h', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JSCTypedArrayStubs.h', u'Source/JavaScriptCore/bytecode/CallLinkStatus.cpp', u'Source/JavaScriptCore/bytecode/CodeBlock.h', u'Source/JavaScriptCore/bytecode/SpeculatedType.cpp', u'Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp', u'Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h', u'Source/JavaScriptCore/debugger/Debugger.cpp', u'Source/JavaScriptCore/debugger/DebuggerActivation.cpp', u'Source/JavaScriptCore/debugger/DebuggerActivation.h', u'Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp', u'Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGThunks.cpp', u'Source/JavaScriptCore/interpreter/Interpreter.cpp', u'Source/JavaScriptCore/jsc.cpp', u'Source/JavaScriptCore/profiler/LegacyProfiler.cpp', u'Source/JavaScriptCore/runtime/Arguments.cpp', u'Source/JavaScriptCore/runtime/Arguments.h', u'Source/JavaScriptCore/runtime/ArrayConstructor.cpp', u'Source/JavaScriptCore/runtime/ArrayConstructor.h', u'Source/JavaScriptCore/runtime/ArrayPrototype.cpp', u'Source/JavaScriptCore/runtime/ArrayPrototype.h', u'Source/JavaScriptCore/runtime/BooleanConstructor.h', u'Source/JavaScriptCore/runtime/BooleanObject.cpp', u'Source/JavaScriptCore/runtime/BooleanObject.h', u'Source/JavaScriptCore/runtime/BooleanPrototype.cpp', u'Source/JavaScriptCore/runtime/BooleanPrototype.h', u'Source/JavaScriptCore/runtime/DateConstructor.cpp', u'Source/JavaScriptCore/runtime/DateConstructor.h', u'Source/JavaScriptCore/runtime/DateInstance.cpp', u'Source/JavaScriptCore/runtime/DateInstance.h', u'Source/JavaScriptCore/runtime/DatePrototype.cpp', u'Source/JavaScriptCore/runtime/DatePrototype.h', u'Source/JavaScriptCore/runtime/Error.h', u'Source/JavaScriptCore/runtime/ErrorConstructor.h', u'Source/JavaScriptCore/runtime/ErrorInstance.cpp', u'Source/JavaScriptCore/runtime/ErrorInstance.h', u'Source/JavaScriptCore/runtime/ErrorPrototype.cpp', u'Source/JavaScriptCore/runtime/ErrorPrototype.h', u'Source/JavaScriptCore/runtime/ExceptionHelpers.cpp', u'Source/JavaScriptCore/runtime/ExceptionHelpers.h', u'Source/JavaScriptCore/runtime/Executable.cpp', u'Source/JavaScriptCore/runtime/Executable.h', u'Source/JavaScriptCore/runtime/FunctionConstructor.h', u'Source/JavaScriptCore/runtime/FunctionPrototype.cpp', u'Source/JavaScriptCore/runtime/FunctionPrototype.h', u'Source/JavaScriptCore/runtime/GetterSetter.cpp', u'Source/JavaScriptCore/runtime/GetterSetter.h', u'Source/JavaScriptCore/runtime/InternalFunction.cpp', u'Source/JavaScriptCore/runtime/InternalFunction.h', u'Source/JavaScriptCore/runtime/JSAPIValueWrapper.h', u'Source/JavaScriptCore/runtime/JSActivation.cpp', u'Source/JavaScriptCore/runtime/JSActivation.h', u'Source/JavaScriptCore/runtime/JSArray.h', u'Source/JavaScriptCore/runtime/JSBoundFunction.cpp', u'Source/JavaScriptCore/runtime/JSBoundFunction.h', u'Source/JavaScriptCore/runtime/JSCJSValue.cpp', u'Source/JavaScriptCore/runtime/JSCJSValueInlines.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/JSCellInlines.h', u'Source/JavaScriptCore/runtime/JSFunction.cpp', u'Source/JavaScriptCore/runtime/JSFunction.h', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObject.h', u'Source/JavaScriptCore/runtime/JSNameScope.cpp', u'Source/JavaScriptCore/runtime/JSNameScope.h', u'Source/JavaScriptCore/runtime/JSNotAnObject.h', u'Source/JavaScriptCore/runtime/JSONObject.cpp', u'Source/JavaScriptCore/runtime/JSONObject.h', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.cpp', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.h', u'Source/JavaScriptCore/runtime/JSProxy.cpp', u'Source/JavaScriptCore/runtime/JSProxy.h', u'Source/JavaScriptCore/runtime/JSScope.cpp', u'Source/JavaScriptCore/runtime/JSSegmentedVariableObject.cpp', u'Source/JavaScriptCore/runtime/JSString.h', u'Source/JavaScriptCore/runtime/JSSymbolTableObject.cpp', u'Source/JavaScriptCore/runtime/JSVariableObject.h', u'Source/JavaScriptCore/runtime/JSWithScope.cpp', u'Source/JavaScriptCore/runtime/JSWithScope.h', u'Source/JavaScriptCore/runtime/JSWrapperObject.cpp', u'Source/JavaScriptCore/runtime/JSWrapperObject.h', u'Source/JavaScriptCore/runtime/MathObject.cpp', u'Source/JavaScriptCore/runtime/MathObject.h', u'Source/JavaScriptCore/runtime/NameConstructor.h', u'Source/JavaScriptCore/runtime/NameInstance.h', u'Source/JavaScriptCore/runtime/NamePrototype.cpp', u'Source/JavaScriptCore/runtime/NamePrototype.h', u'Source/JavaScriptCore/runtime/NativeErrorConstructor.cpp', u'Source/JavaScriptCore/runtime/NativeErrorConstructor.h', u'Source/JavaScriptCore/runtime/NumberConstructor.cpp', u'Source/JavaScriptCore/runtime/NumberConstructor.h', u'Source/JavaScriptCore/runtime/NumberObject.cpp', u'Source/JavaScriptCore/runtime/NumberObject.h', u'Source/JavaScriptCore/runtime/NumberPrototype.cpp', u'Source/JavaScriptCore/runtime/NumberPrototype.h', u'Source/JavaScriptCore/runtime/ObjectConstructor.h', u'Source/JavaScriptCore/runtime/ObjectPrototype.cpp', u'Source/JavaScriptCore/runtime/ObjectPrototype.h', u'Source/JavaScriptCore/runtime/PropertyMapHashTable.h', u'Source/JavaScriptCore/runtime/PropertyTable.cpp', u'Source/JavaScriptCore/runtime/RegExp.h', u'Source/JavaScriptCore/runtime/RegExpConstructor.cpp', u'Source/JavaScriptCore/runtime/RegExpConstructor.h', u'Source/JavaScriptCore/runtime/RegExpMatchesArray.cpp', u'Source/JavaScriptCore/runtime/RegExpMatchesArray.h', u'Source/JavaScriptCore/runtime/RegExpObject.cpp', u'Source/JavaScriptCore/runtime/RegExpObject.h', u'Source/JavaScriptCore/runtime/RegExpPrototype.cpp', u'Source/JavaScriptCore/runtime/RegExpPrototype.h', u'Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp', u'Source/JavaScriptCore/runtime/SparseArrayValueMap.h', u'Source/JavaScriptCore/runtime/StrictEvalActivation.h', u'Source/JavaScriptCore/runtime/StringConstructor.h', u'Source/JavaScriptCore/runtime/StringObject.cpp', u'Source/JavaScriptCore/runtime/StringObject.h', u'Source/JavaScriptCore/runtime/StringPrototype.cpp', u'Source/JavaScriptCore/runtime/StringPrototype.h', u'Source/JavaScriptCore/runtime/Structure.cpp', u'Source/JavaScriptCore/runtime/Structure.h', u'Source/JavaScriptCore/runtime/StructureChain.cpp', u'Source/JavaScriptCore/runtime/StructureChain.h', u'Source/JavaScriptCore/runtime/StructureInlines.h', u'Source/JavaScriptCore/runtime/StructureRareData.cpp', u'Source/JavaScriptCore/runtime/StructureRareData.h', u'Source/JavaScriptCore/runtime/SymbolTable.h', u'Source/JavaScriptCore/runtime/VM.cpp', u'Source/JavaScriptCore/runtime/WriteBarrier.h', u'Source/JavaScriptCore/testRegExp.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/IDBBindingUtilities.cpp', u'Source/WebCore/bindings/js/JSAttrCustom.cpp', u'Source/WebCore/bindings/js/JSAudioTrackCustom.cpp', u'Source/WebCore/bindings/js/JSAudioTrackListCustom.cpp', u'Source/WebCore/bindings/js/JSBlobCustom.cpp', u'Source/WebCore/bindings/js/JSCSSRuleCustom.cpp', u'Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp', u'Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp', u'Source/WebCore/bindings/js/JSCanvasRenderingContextCustom.cpp', u'Source/WebCore/bindings/js/JSDOMBinding.cpp', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMFormDataCustom.cpp', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMStringListCustom.cpp', u'Source/WebCore/bindings/js/JSDOMWindowBase.cpp', u'Source/WebCore/bindings/js/JSDOMWindowBase.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDOMWindowShell.cpp', u'Source/WebCore/bindings/js/JSDOMWindowShell.h', u'Source/WebCore/bindings/js/JSEventTargetCustom.cpp', u'Source/WebCore/bindings/js/JSHistoryCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp', u'Source/WebCore/bindings/js/JSLocationCustom.cpp', u'Source/WebCore/bindings/js/JSMessageChannelCustom.cpp', u'Source/WebCore/bindings/js/JSMessagePortCustom.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/JSNodeFilterCustom.cpp', u'Source/WebCore/bindings/js/JSNodeIteratorCustom.cpp', u'Source/WebCore/bindings/js/JSPluginElementFunctions.h', u'Source/WebCore/bindings/js/JSSVGElementInstanceCustom.cpp', u'Source/WebCore/bindings/js/JSSharedWorkerCustom.cpp', u'Source/WebCore/bindings/js/JSStyleSheetCustom.cpp', u'Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp', u'Source/WebCore/bindings/js/JSTextTrackCustom.cpp', u'Source/WebCore/bindings/js/JSTextTrackListCustom.cpp', u'Source/WebCore/bindings/js/JSTrackCustom.cpp', u'Source/WebCore/bindings/js/JSTreeWalkerCustom.cpp', u'Source/WebCore/bindings/js/JSVideoTrackCustom.cpp', u'Source/WebCore/bindings/js/JSVideoTrackListCustom.cpp', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h', u'Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp', u'Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp', u'Source/WebCore/bindings/js/JSXPathResultCustom.cpp', u'Source/WebCore/bindings/js/ScriptDebugServer.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/js/SerializedScriptValue.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMUtility.mm', u'Source/WebCore/bindings/objc/WebScriptObject.mm', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestException.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestNode.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestObj.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h', u'Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp', u'Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.h', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/c/c_utility.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/objc/objc_runtime.mm', u'Source/WebCore/bridge/qt/qt_instance.cpp', u'Source/WebCore/bridge/qt/qt_pixmapruntime.cpp', u'Source/WebCore/bridge/qt/qt_runtime.cpp', u'Source/WebCore/bridge/runtime_array.cpp', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.cpp', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/Api/qwebelement.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/JSNPMethod.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/JSNPMethod.h', u'Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.h', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp', u'Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp']" exit_code: 1 Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1590: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/WebKit/qt/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 265 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Hahnenberg

Comment 3 2013-08-13 17:11:20 PDT

Comment on attachment 208691 [details] the patch r=me with qt stuff.

Filip Pizlo

Comment 4 2013-08-13 19:41:07 PDT

Landed in http://trac.webkit.org/changeset/154038

Note You need to log in before you can comment on or make changes to this bug.