Remotely hosted plugins don’t work in window-server-hosted WebKit1 views

• Component: Plug-ins
• Status: RESOLVED FIXED

[Tim Horton]

The plugin's layers are always hosted in the app, but the rest of the layer tree is (if requested) window-server-hosted. We need to conditionally create the plugin’s layers in the WindowServer if need be.

<rdar://problem/14717572>

[Tim Horton]

Created attachment 208578 [details]
patch

[Tim Horton]

Created attachment 208667 [details]
patch with dynamic updating

[Anders Carlsson]

Comment on attachment 208667 [details]
patch with dynamic updating

View in context: https://bugs.webkit.org/attachment.cgi?id=208667&action=review

> Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:259
> +    BOOL shouldHostLayersInWindowServer = [self windowHostsLayersInWindowServer];

I think you should declare this as bool instead.

> Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:260
> +    if (_hostsLayersInWindowServer != shouldHostLayersInWindowServer)

Otherwise this might not do what you want it to.

[Tim Horton]

Thanks, Anders!

http://trac.webkit.org/changeset/154019

[Antti Koivisto]

This made many plugin tests time out: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r154019%20(9412)/results.html

[Jer Noble]

Reverted in http://trac.webkit.org/changeset/154050.  Caused >50 layout tests to fail, breaking the WebKit1 test bots completely.

[Tim Horton]

Reopening since it's reverted. The tests all pass locally, I'll have to test on Mountain Lion.

[Tim Horton]

MIG .defs were in the wrong order

http://trac.webkit.org/changeset/154078