Bug 119709

Summary: Remotely hosted plugins don’t work in window-server-hosted WebKit1 views
Product: WebKit Reporter: Tim Horton <thorton>
Component: Plug-insAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, jer.noble, koivisto, sam, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
andersca: review+
patch with dynamic updating andersca: review+

Tim Horton
Reported 2013-08-12 17:40:27 PDT
The plugin's layers are always hosted in the app, but the rest of the layer tree is (if requested) window-server-hosted. We need to conditionally create the plugin’s layers in the WindowServer if need be. <rdar://problem/14717572>
Attachments
patch (6.92 KB, patch)
2013-08-12 17:54 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
patch with dynamic updating (18.38 KB, patch)
2013-08-13 13:07 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-08-12 17:54:35 PDT
Created attachment 208578 [details] patch
Tim Horton
Comment 2 2013-08-13 13:07:21 PDT
Created attachment 208667 [details] patch with dynamic updating
Anders Carlsson
Comment 3 2013-08-13 13:09:13 PDT
Comment on attachment 208667 [details] patch with dynamic updating View in context: https://bugs.webkit.org/attachment.cgi?id=208667&action=review > Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:259 > + BOOL shouldHostLayersInWindowServer = [self windowHostsLayersInWindowServer]; I think you should declare this as bool instead. > Source/WebKit/mac/Plugins/Hosted/WebHostedNetscapePluginView.mm:260 > + if (_hostsLayersInWindowServer != shouldHostLayersInWindowServer) Otherwise this might not do what you want it to.
Tim Horton
Comment 4 2013-08-13 13:33:20 PDT
Thanks, Anders! http://trac.webkit.org/changeset/154019
Antti Koivisto
Comment 5 2013-08-14 06:00:39 PDT
This made many plugin tests time out: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r154019%20(9412)/results.html
Jer Noble
Comment 6 2013-08-14 09:18:49 PDT
Reverted in http://trac.webkit.org/changeset/154050. Caused >50 layout tests to fail, breaking the WebKit1 test bots completely.
Tim Horton
Comment 7 2013-08-14 10:14:52 PDT
Reopening since it's reverted. The tests all pass locally, I'll have to test on Mountain Lion.
Tim Horton
Comment 8 2013-08-14 16:07:31 PDT
MIG .defs were in the wrong order http://trac.webkit.org/changeset/154078
Note You need to log in before you can comment on or make changes to this bug.