Summary: | Remove Node::attach() and ContainerNode::attach() | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, cmarcelo, commit-queue, eflews.bot, esprehn+autocc, gtk-ews, gyuyoung.kim, japhet, kangil.han, kling, philn, rniwa, sam, xan.lopez | ||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2013-08-12 14:03:15 PDT
Created attachment 208563 [details]
possibly patch
Comment on attachment 208563 [details] possibly patch Attachment 208563 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1445487 Comment on attachment 208563 [details] possibly patch Attachment 208563 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1455188 Comment on attachment 208563 [details] possibly patch Attachment 208563 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1449294 Created attachment 208570 [details]
another
Comment on attachment 208570 [details] another Attachment 208570 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1459173 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/inserting/editing-empty-divs.html editing/selection/caret-rtl.html fullscreen/full-screen-render-inline.html editing/style/remove-underline-from-stylesheet.html editing/selection/caret-ltr-right.html fast/repaint/caret-jump-between-nodes.html http/tests/inspector/inspect-element.html editing/selection/caret-ltr-2.html fast/multicol/span/clone-summary.html fast/html/details-remove-child-2.html editing/pasteboard/paste-match-style-001.html editing/selection/caret-rtl-2-left.html fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html editing/style/remove-underline-across-paragraph.html editing/selection/caret-ltr-2-left.html fast/html/details-add-child-2.html editing/style/remove-underline.html fast/html/details-open2.html editing/selection/4983858.html editing/selection/caret-rtl-2.html editing/style/remove-underline-after-paragraph.html editing/selection/caret-rtl-right.html editing/inserting/editable-html-element.html editing/style/remove-underline-in-bold.html editing/style/remove-underline-after-paragraph-in-bold.html editing/style/typing-style-003.html editing/selection/caret-ltr.html fast/loader/javascript-url-in-object.html editing/style/underline.html Created attachment 208576 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 208570 [details] another Attachment 208570 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1459183 Comment on attachment 208570 [details] another Attachment 208570 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1378424 New failing tests: editing/style/remove-underline-across-paragraph-in-bold.html editing/inserting/editing-empty-divs.html editing/selection/caret-rtl.html editing/style/typing-style-003.html editing/selection/caret-ltr-right.html http/tests/inspector/inspect-element.html editing/pasteboard/copy-image-with-alt-text.html editing/pasteboard/paste-match-style-001.html editing/selection/caret-rtl-2-left.html editing/style/remove-underline-across-paragraph.html editing/selection/caret-ltr-2-left.html fast/html/details-remove-child-2.html fast/html/details-add-child-2.html editing/style/remove-underline.html fast/html/details-open2.html editing/selection/4983858.html editing/selection/caret-rtl-2.html editing/style/remove-underline-after-paragraph.html editing/selection/caret-rtl-right.html editing/inserting/editable-html-element.html editing/style/remove-underline-in-bold.html editing/style/remove-underline-after-paragraph-in-bold.html editing/style/remove-underline-from-stylesheet.html editing/selection/caret-ltr.html editing/selection/caret-ltr-2.html editing/style/underline.html Created attachment 208609 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Created attachment 208629 [details]
another
Comment on attachment 208629 [details] another Attachment 208629 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1451473 Created attachment 208651 [details]
yet another
Comment on attachment 208651 [details] yet another Attachment 208651 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1446748 Comment on attachment 208651 [details] yet another Attachment 208651 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1458429 New failing tests: fullscreen/video-controls-override.html Created attachment 208666 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 208651 [details] yet another Attachment 208651 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1456540 New failing tests: fullscreen/video-controls-override.html Created attachment 208675 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 208651 [details] yet another Attachment 208651 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1453665 New failing tests: fullscreen/video-controls-override.html Created attachment 208697 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Created attachment 208720 [details]
more
Comment on attachment 208720 [details]
more
r=me, this is very cool.
Like I mentioned on IRC, I think we can micro-optimize some things here but now is hardly the time. :)
It seems like you've already figured out what was wrong with the editing test? Let me know if you still needed my help. I assume you've figured it out for now. |