Bug 119690
| Summary: | [CSS Shapes] Eliminate GraphicsContext3D::ImageExtractor dependency | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Muller <giles_joplin> |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 116643 | ||
Hans Muller
The reviewer for bug 116643 had asked for the GraphicsContext3D dependency in Shapes.cpp to be removed.
The original plan was to refactor GraphicsContext3D::ImageExtractor et al, to remove its dependency on the rest of the WebGL code. See:
The new plan is to render the shape's StyleImage instead: https://bugs.webkit.org/show_bug.cgi?id=119634
Use ImageBuffer::create() to create an ImageBuffer of the right size.
Draw the Image* with the GraphicsContext returned by imageBuffer->context().
Use ImageBuffer::getUnmultipliedImageData() to extract the RGBA pixels data.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Hans Muller
This doesn't need to be a separate bug.