Bug 119664

Summary: Cleanup MediaQueryListListener
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, macpherson, menard, rakuco, simon.fraser, spenap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 119768    
Bug Blocks:    
Attachments:
Description Flags
Patch kling: review+

Description Sam Weinig 2013-08-11 12:25:10 PDT 
Cleanup MediaQueryListListener
Comment 1 Sam Weinig 2013-08-11 12:38:51 PDT 
Created attachment 208503 [details]
Patch
Comment 2 Andreas Kling 2013-08-11 12:49:38 PDT 
Comment on attachment 208503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208503&action=review

> Source/WebCore/ChangeLog:8
> +        Make MediaQueryListListener a proper WebIDL callback.

Nice.

Guess you might need to rebaseline the bindings tests.
Comment 3 Sam Weinig 2013-08-11 13:10:11 PDT 
Committed r153925: <http://trac.webkit.org/changeset/153925>
Comment 4 WebKit Commit Bot 2013-08-13 13:50:14 PDT 
Re-opened since this is blocked by bug 119768
Comment 5 Sam Weinig 2013-08-13 18:20:39 PDT 
Re-landed in r154035 with updated test and results.
Comment 6 Simon Fraser (smfr) 2013-08-14 12:42:49 PDT 
Bindings generation tests are still failing:
http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29?numbuilds=100
Comment 7 Sam Weinig 2013-08-14 17:52:02 PDT 
(In reply to comment #6)
> Bindings generation tests are still failing:
> http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29?numbuilds=100

Fixed in r154087.
Comment 9 Sam Weinig 2013-08-15 10:42:45 PDT 
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Bindings generation tests are still failing:
> > > http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29?numbuilds=100
> > 
> > Fixed in r154087.
> 
> Hi: the binding generation tests are still failing in GTK. Before r154087 this was the error: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/39835/steps/bindings-generation-tests/logs/stdio, after r154087, the error is now: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/39836/steps/bindings-generation-tests/logs/stdio

That looks like an unrelated change.