Summary: | Make Page::settings() return a reference. | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||||
Component: | WebCore Misc. | Assignee: | Andreas Kling <kling> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, kling, philn, rniwa, webkit-ews, xan.lopez | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Andreas Kling
2013-08-11 09:43:54 PDT
Created attachment 208496 [details]
Patch
Attachment 208496 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseContext.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedPage.cpp', u'Source/WebCore/history/PageCache.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLLinkElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/page/CaptionUserPreferences.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/Console.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Navigator.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageConsole.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/make_settings.pl', u'Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp', u'Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp', u'Source/WebCore/platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/storage/Storage.cpp', u'Source/WebCore/storage/StorageNamespaceImpl.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/InternalSettings.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp', u'Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm']" exit_code: 1
Source/WebCore/html/ImageDocument.cpp:377: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 1 in 60 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 208496 [details] Patch Attachment 208496 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1405800 Comment on attachment 208496 [details] Patch Attachment 208496 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1410800 Comment on attachment 208496 [details] Patch Attachment 208496 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1399817 Comment on attachment 208496 [details] Patch Attachment 208496 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1413809 Comment on attachment 208496 [details] Patch Attachment 208496 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1409903 Created attachment 208497 [details]
Patch! Part Deux
Comment on attachment 208497 [details] Patch! Part Deux Attachment 208497 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1409907 Comment on attachment 208497 [details] Patch! Part Deux Attachment 208497 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1399825 Created attachment 208499 [details]
Patch III: #awyiss
Comment on attachment 208499 [details] Patch III: #awyiss Attachment 208499 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1444099 Created attachment 208500 [details]
Patch IV: Bueller?
Comment on attachment 208500 [details] Patch IV: Bueller? Attachment 208500 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1412792 Created attachment 208501 [details]
Patch V: Is this on?
Comment on attachment 208501 [details] Patch V: Is this on? Rejecting attachment 208501 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 208501, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/1410825 Created attachment 208502 [details]
Patch for landing
Comment on attachment 208502 [details] Patch for landing Clearing flags on attachment: 208502 Committed r153927: <http://trac.webkit.org/changeset/153927> All reviewed patches have been landed. Closing bug. |