Bug 119660

Summary:

Make some things that return never-null pointers return references instead.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, gyuyoung.kim, kling, philn, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+, webkit-ews: commit-queue-
Patch for landing perhaps.	webkit-ews: commit-queue-
Patch for totally landing	none
Patch for actually landing	none

Description Andreas Kling 2013-08-11 06:51:10 PDT

Things like ensureFoo() that are guaranteed to always return an object should just return references.

Comment 1 Andreas Kling 2013-08-11 06:57:10 PDT

Created attachment 208492 [details]
Patch

Comment 2 Early Warning System Bot 2013-08-11 07:05:26 PDT

Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1414942

Comment 3 EFL EWS Bot 2013-08-11 07:06:17 PDT

Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1411860

Comment 4 Early Warning System Bot 2013-08-11 07:07:35 PDT

Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1441269

Comment 5 EFL EWS Bot 2013-08-11 07:19:48 PDT

Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1401792

Comment 6 Andreas Kling 2013-08-11 07:22:27 PDT

Created attachment 208493 [details]
Patch for landing perhaps.

Comment 7 Early Warning System Bot 2013-08-11 07:44:18 PDT

Comment on attachment 208493 [details]
Patch for landing perhaps.

Attachment 208493 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1414948

Comment 8 Early Warning System Bot 2013-08-11 07:45:43 PDT

Comment on attachment 208493 [details]
Patch for landing perhaps.

Attachment 208493 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1445051

Comment 9 Andreas Kling 2013-08-11 08:32:24 PDT

Created attachment 208494 [details]
Patch for totally landing

Comment 10 Andreas Kling 2013-08-11 08:33:01 PDT

Created attachment 208495 [details]
Patch for actually landing

Comment 11 Andreas Kling 2013-08-11 13:25:31 PDT

Comment on attachment 208495 [details]
Patch for actually landing

Clearing flags on attachment: 208495

Committed r153926: <http://trac.webkit.org/changeset/153926>

Comment 12 Andreas Kling 2013-08-11 13:25:38 PDT

All reviewed patches have been landed.  Closing bug.