Summary: | ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in WebCore::RenderGeometryMap::mapToContainer | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> | ||||||||||||||||||||||||
Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||||||||||||||||
Status: | RESOLVED DUPLICATE | ||||||||||||||||||||||||||
Severity: | Normal | CC: | buildbot, bunhere, cdumez, commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, hyatt, kondapallykalyan, ossy, pdr, rniwa, sabouhallawa, schenney, sergio, simon.fraser | ||||||||||||||||||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
Hardware: | PC | ||||||||||||||||||||||||||
OS: | Linux | ||||||||||||||||||||||||||
Bug Depends on: | |||||||||||||||||||||||||||
Bug Blocks: | 116980 | ||||||||||||||||||||||||||
Attachments: |
|
Description
Renata Hodovan
2013-08-09 05:58:53 PDT
Created attachment 208424 [details]
Test case
Created attachment 221367 [details]
New test case
The previous test doesn't produce the assertion above anymore, but we can achieve it with this new one.
As a side note, I have also tested it with the newest EFL debug build in EWebLauncher and MiniBrowser on r161958 (and not in QtTestBrowser as the backtrace suggest). Created attachment 225363 [details] Proposed patch Backported from Blink: https://codereview.chromium.org/143363004 Comment on attachment 225363 [details] Proposed patch Attachment 225363 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6233206076473344 New failing tests: svg/transforms/svg-geometry-crash.html Created attachment 225368 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 225363 [details] Proposed patch Attachment 225363 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4864332353503232 New failing tests: svg/transforms/svg-geometry-crash.html Created attachment 225371 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 225363 [details] Proposed patch Attachment 225363 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4896495216099328 New failing tests: svg/transforms/svg-geometry-crash.html Created attachment 225373 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 225382 [details]
Proposed patch
Created attachment 225389 [details]
Proposed patch
Comment on attachment 225389 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=225389&action=review r=me but the tests should not need to dump pixel results. > LayoutTests/ChangeLog:14 > + * platform/efl/svg/transforms/svg-geometry-crash-expected.png: Added. > + * platform/efl/svg/transforms/svg-geometry-crash-expected.txt: Added. > + * platform/mac/svg/transforms/svg-geometry-crash-expected.png: Added. > + * platform/mac/svg/transforms/svg-geometry-crash-expected.txt: Added. > + * svg/transforms/svg-geometry-crash.html: Added. Why can't these be dumpAsText() tests? Created attachment 225460 [details]
Proposed patch
Comment on attachment 225460 [details]
Proposed patch
You shouldn't set r+ yourself, but add "Reviewed by Simon Fraser." to the changelog and set only cq?
Created attachment 225464 [details]
Proposed patch
Comment on attachment 225464 [details] Proposed patch Clearing flags on attachment: 225464 Committed r164861: <http://trac.webkit.org/changeset/164861> All reviewed patches have been landed. Closing bug. The fix committed for this bug was wrong. It was reverted by Blink because it broke their SVG display. It also broke the WebKit SVG search. Bug https://bugs.webkit.org/show_bug.cgi?id=138439 was logged to track reverting this change. The same assertion is still firing with or without this change and it is tracked by bug https://bugs.webkit.org/show_bug.cgi?id=122027. (In reply to comment #19) > The same assertion is still firing with or without this change > and it is tracked by bug https://bugs.webkit.org/show_bug.cgi?id=122027. I was wrong about the relationship between the assertion here and the assertion filed in the https://bugs.webkit.org/show_bug.cgi?id=122027. The assertion are different and actually they are in different overloaded functions. Reopening to attach new patch. Created attachment 241152 [details]
Patch
Comment on attachment 241152 [details] Patch By mistake the patch of https://bugs.webkit.org/show_bug.cgi?id=138439 got into this one and reopened it. I am obsoleting it and closing the bug again. *** This bug has been marked as a duplicate of bug 138439 *** |