Bug 119619

Summary:

[Win] TestWebKitAPI fails to link.

Product:

WebKit

Reporter:

peavo

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

peavo

Reported 2013-08-09 03:23:34 PDT

Linking TestWebKitAPI fails with the following error: error LNK2019: unresolved external symbol "protected: class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::frameOrientationAtIndex(unsigned int)" (?frameOrientationAtIndex@BitmapImage@WebCore@@IAE?AVImageOrientation@2@I@Z) referenced in function "public: virtual class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::orientationForCurrentFrame(void)" (?orientationForCurrentFrame@BitmapImage@WebCore@@UAE?AVImageOrientation@2@XZ)

Attachments
Patch (2.17 KB, patch) 2013-08-09 03:29 PDT, peavo	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

peavo

Comment 1 2013-08-09 03:29:14 PDT

Created attachment 208412 [details] Patch

Brent Fulgham

Comment 2 2013-08-12 09:23:06 PDT

Comment on attachment 208412 [details] Patch r=me

WebKit Commit Bot

Comment 3 2013-08-12 09:31:50 PDT

Comment on attachment 208412 [details] Patch Clearing flags on attachment: 208412 Committed r153943: <http://trac.webkit.org/changeset/153943>

WebKit Commit Bot

Comment 4 2013-08-12 09:31:51 PDT

All reviewed patches have been landed. Closing bug.

Alex Christensen

Comment 5 2013-08-13 21:45:26 PDT

The parameter of this function is a size_t, which is the size of a pointer, which changes with the 64-bit build. This should have been the following: symbolWithPointer(?frameOrientationAtIndex@BitmapImage@WebCore@@IAE?AVImageOrientation@2@I@Z, ?frameOrientationAtIndex@BitmapImage@WebCore@@IEAA?AVImageOrientation@2@_K@Z) I'll commit this manually. It doesn't break anything any bots are doing right now.

Note You need to log in before you can comment on or make changes to this bug.