Bug 119619

Summary: [Win] TestWebKitAPI fails to link.
Product: WebKit Reporter: peavo
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Severity: Normal CC: achristensen, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Description Flags
Patch none

Description peavo 2013-08-09 03:23:34 PDT
Linking TestWebKitAPI fails with the following error:

error LNK2019: unresolved external symbol "protected: class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::frameOrientationAtIndex(unsigned int)" (?frameOrientationAtIndex@BitmapImage@WebCore@@IAE?AVImageOrientation@2@I@Z) referenced in function "public: virtual class WebCore::ImageOrientation __thiscall WebCore::BitmapImage::orientationForCurrentFrame(void)" (?orientationForCurrentFrame@BitmapImage@WebCore@@UAE?AVImageOrientation@2@XZ)
Comment 1 peavo 2013-08-09 03:29:14 PDT
Created attachment 208412 [details]
Comment 2 Brent Fulgham 2013-08-12 09:23:06 PDT
Comment on attachment 208412 [details]

Comment 3 WebKit Commit Bot 2013-08-12 09:31:50 PDT
Comment on attachment 208412 [details]

Clearing flags on attachment: 208412

Committed r153943: <http://trac.webkit.org/changeset/153943>
Comment 4 WebKit Commit Bot 2013-08-12 09:31:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alex Christensen 2013-08-13 21:45:26 PDT
The parameter of this function is a size_t, which is the size of a pointer, which changes with the 64-bit build.  This should have been the following:

symbolWithPointer(?frameOrientationAtIndex@BitmapImage@WebCore@@IAE?AVImageOrientation@2@I@Z, ?frameOrientationAtIndex@BitmapImage@WebCore@@IEAA?AVImageOrientation@2@_K@Z)

I'll commit this manually.  It doesn't break anything any bots are doing right now.