Bug 119580 – Move :optional/:required/:*range selector related virtuals off of Element.

• Component: CSS
• Status: NEW

[Andreas Kling]

Move :optional/:required/:*range selector related virtuals off of Element.

[Andreas Kling]

Created attachment 208355 [details]
Patch

[WebKit Commit Bot]

Attachment 208355 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/SelectorChecker.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/html/HTMLButtonElement.h', u'Source/WebCore/html/HTMLFormControlElement.h', u'Source/WebCore/html/HTMLInputElement.h', u'Source/WebCore/html/HTMLKeygenElement.h', u'Source/WebCore/html/HTMLSelectElement.h', u'Source/WebCore/html/HTMLTextAreaElement.h']" exit_code: 1
Source/WebCore/html/HTMLSelectElement.h:149:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 208355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208355&action=review

> Source/WebCore/html/HTMLFormControlElement.h:70
> +    virtual bool isOptionalFormControl() const { return false; }
> +    virtual bool isRequiredFormControl() const { return false; }

Since these are moved down from Element to HTMLFormControlElement, they could just be named isOptional and isRequired. The longer names were needed because this was in Element.

>> Source/WebCore/html/HTMLSelectElement.h:149
>> +    virtual bool isOptionalFormControl() const OVERRIDE{ return !isRequiredFormControl(); }
> 
> Missing space before {  [whitespace/braces] [5]

The stylebot, he’s right!

[EFL EWS Bot]

Comment on attachment 208355 [details]
Patch

Attachment 208355 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1389377

[Build Bot]

Comment on attachment 208355 [details]
Patch

Attachment 208355 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1486084