Bug 119577

Summary: [Qt] REGRESSION(r153664): ThirdParty Angle build is broken.
Product: WebKit Reporter: Zoltan Arvai <zarvai>
Component: ANGLEAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, allan.jensen, commit-queue, dino, jturcotte, kadam, kondapallykalyan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 119452    
Attachments:
Description Flags
build log
none
buildfix none

Zoltan Arvai
Reported 2013-08-08 09:17:09 PDT
Created attachment 208348 [details] build log It seems a header file is missing from the update. I found a SoftLinking.h file in Source/WebCore/platform/win. Should we use that one? C:\buildslave\qt-windows-32bit-release\build\Source\ThirdParty\ANGLE\include\GLES2/gl2softlinking.h(25) : fatal error C1083: Cannot open include file: 'SoftLinking.h': No such file or directory util.cpp Full build log attached.
Attachments
build log (44.55 KB, application/zip)
2013-08-08 09:17 PDT, Zoltan Arvai 		no flags
Details
buildfix (1.12 KB, patch)
2013-08-09 05:58 PDT, Zoltan Arvai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-08-08 10:10:09 PDT
Don't use SoftLinking.h while building ANGLE. To get the soft linking to work you need to define ANGLE_WEBKIT_WIN (which I did in translatorCommon.props, libEGLCommon.props, and libGLESv2Common.props in https://trac.webkit.org/changeset/153664) while compiling ANGLE to produce an unaltered dll. When compiling WebCore with WebGL enabled, do not define ANGLE_WEBKIT_WIN and it will use my soft link headers (eglsoftlinking.h and gl2softlinking.h). Are you planning to get WebGL working on Qt win? Let me know if you run into any problems.
Zoltan Arvai
Comment 2 2013-08-09 05:58:48 PDT
Created attachment 208422 [details] buildfix Adding ANGLE_WEBKIT_WIN definition to Target.pri.
Allan Sandfeld Jensen
Comment 3 2013-08-09 06:02:42 PDT
(In reply to comment #1) > Don't use SoftLinking.h while building ANGLE. To get the soft linking to work you need to define ANGLE_WEBKIT_WIN (which I did in translatorCommon.props, libEGLCommon.props, and libGLESv2Common.props in https://trac.webkit.org/changeset/153664) while compiling ANGLE to produce an unaltered dll. When compiling WebCore with WebGL enabled, do not define ANGLE_WEBKIT_WIN and it will use my soft link headers (eglsoftlinking.h and gl2softlinking.h). > > Are you planning to get WebGL working on Qt win? Let me know if you run into any problems. WebGL on Qt has been working for years.
WebKit Commit Bot
Comment 4 2013-08-09 06:25:50 PDT
Comment on attachment 208422 [details] buildfix Clearing flags on attachment: 208422 Committed r153888: <http://trac.webkit.org/changeset/153888>
WebKit Commit Bot
Comment 5 2013-08-09 06:25:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.