Bug 119536

Summary: Refactor highestEditableRoot to avoid a redundant call to rendererIsEditable
Product: WebKit Reporter: Vani Hegde <vani.hegde>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, enrica, rniwa, vanivhegde
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Cleanup benjamin: review+, benjamin: commit-queue-

Vani Hegde
Reported 2013-08-06 21:54:01 PDT
Minor refactoring in highestEditableRoot to avoid a redundant call to rendererIsEditable
Attachments
Patch (2.05 KB, patch)
2013-08-06 21:59 PDT, Vani Hegde 		no flags
DetailsFormatted DiffDiff
Cleanup (3.19 KB, patch)
2013-08-16 18:19 PDT, Ryosuke Niwa 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vani Hegde
Comment 1 2013-08-06 21:59:41 PDT
Created attachment 208236 [details] Patch
Ryosuke Niwa
Comment 2 2013-08-10 22:37:30 PDT
Comment on attachment 208236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208236&action=review > Source/WebCore/editing/htmlediting.cpp:123 > + if (highestRoot->hasTagName(bodyTag)) > + return highestRoot; > + > + node = highestRoot->parentNode(); Please don't repeat the code. We can rearrange the code inside the loop instead.
Ryosuke Niwa
Comment 3 2013-08-16 17:34:19 PDT
Landed in https://chromiumcodereview.appspot.com/22288004.
Ryosuke Niwa
Comment 4 2013-08-16 18:19:40 PDT
Created attachment 208971 [details] Cleanup
Ryosuke Niwa
Comment 5 2013-08-16 18:23:58 PDT
Comment on attachment 208971 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=208971&action=review > Source/WebCore/WebCore.exp.in:-2255 > -__ZNK7WebCore4Node18rendererIsEditableENS0_13EditableLevelE Apparently this is still used. Reverting that.
Benjamin Poulain
Comment 6 2013-08-16 18:27:22 PDT
Comment on attachment 208971 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=208971&action=review > Source/WebCore/WebCore.exp.in:-2255 > -__ZNK7WebCore4Node18rendererIsEditableENS0_13EditableLevelE You can't do that. > Source/WebCore/editing/htmlediting.cpp:116 > Node* highestRoot = editableRootForPosition(position, editableType); Rename to highestEditableRoot? rootEditableNode?
Ryosuke Niwa
Comment 7 2013-08-16 18:30:20 PDT
Committed r154212: <http://trac.webkit.org/changeset/154212>
Note You need to log in before you can comment on or make changes to this bug.