Bug 119512

Summary:

use PlatformArchitecture variable in Visual Studio

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
patch	bfulgham: review+

Alex Christensen

Reported 2013-08-06 00:16:10 PDT

Visual Studio has an environment variable named PlatformArchitecture that evaluates to "32" for 32-bit builds and "64" for 64-bit builds. There are many places in the Windows build where we have written obj32, bin32, or lib32. Many of these can be replaced by obj$(PlatformArchitecture), obj%PlatformArchitecture%, etc. I had some trouble with the .sh shell scripts, work-around-vs-dependency-tracking-bugs.py, and copyForwardingHeaders.cmd, so those can be done in a separate patch. This is a large step towards getting a 64-bit build on Windows.

Attachments
Patch (867.75 KB, patch) 2013-08-06 00:42 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (863.70 KB, patch) 2013-08-19 16:39 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (851.28 KB, patch) 2013-08-19 16:51 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
patch (849.86 KB, patch) 2013-08-20 09:48 PDT, Alex Christensen	bfulgham: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-08-06 00:27:16 PDT

I also had some trouble with WebKitExportGenerator. To prevent this patch from being too large and complicated, I'll do the rest in another patch.

Alex Christensen

Comment 2 2013-08-06 00:42:53 PDT

Created attachment 208171 [details] Patch

Alex Christensen

Comment 3 2013-08-06 00:44:55 PDT

This patch has some quirks. It puts some things (a build log, some scripts) into an obj directory instead of obj32.

Alex Christensen

Comment 4 2013-08-06 10:51:30 PDT

Comment on attachment 208171 [details] Patch This needs more work before it's done, and it would completely break the 64-bit build until it is done.

Alex Christensen

Comment 5 2013-08-19 16:36:19 PDT

Let's do this in small steps, starting with the vxcproj, props, and filters. They work without modifying behavior on the 32-bit build. It will destroy any hopes of manually hacking together a 64-bit build until we're done, but I'm the only one who's doing that right now, anyways.

Alex Christensen

Comment 6 2013-08-19 16:39:02 PDT

Created attachment 209138 [details] Patch

Alex Christensen

Comment 7 2013-08-19 16:40:48 PDT

Comment on attachment 209138 [details] Patch I got carried away with my regular expressions. This needs to be done manually.

Alex Christensen

Comment 8 2013-08-19 16:51:49 PDT

Created attachment 209139 [details] Patch

Alex Christensen

Comment 9 2013-08-20 09:48:08 PDT

Created attachment 209203 [details] patch I forgot to undo my changes to a .make file in the previous patch. This one's good.