Bug 119497 – Move style recalculation out from Element

• Component: DOM
• Status: RESOLVED FIXED

[Antti Koivisto]

Element currently does too much. The current Element::recalcStyle() and the related functions can be turned into standalone functions that operate on DOM tree. This will also give more freedom for future refactoring, for example making style recalculation non-recursive.

[Antti Koivisto]

Created attachment 208153 [details]
for bots

[WebKit Commit Bot]

Attachment 208153 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/StyleRecalculation.cpp', u'Source/WebCore/css/StyleRecalculation.h', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/ElementShadow.cpp', u'Source/WebCore/dom/ElementShadow.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/PseudoElement.h', u'Source/WebCore/dom/ShadowRoot.cpp', u'Source/WebCore/dom/ShadowRoot.h', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/Text.h', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.h', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.h', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.h', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLOptionElement.h', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/DocumentWriter.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGElement.h', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h']" exit_code: 1
Source/WebCore/css/StyleRecalculation.cpp:123:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/dom/Document.h:49:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 208153 [details]
for bots

Attachment 208153 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1351018

[Early Warning System Bot]

Comment on attachment 208153 [details]
for bots

Attachment 208153 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1392007

[Build Bot]

Comment on attachment 208153 [details]
for bots

Attachment 208153 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1392010

[EFL EWS Bot]

Comment on attachment 208153 [details]
for bots

Attachment 208153 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1343084

[Build Bot]

Comment on attachment 208153 [details]
for bots

Attachment 208153 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1396011

[EFL EWS Bot]

Comment on attachment 208153 [details]
for bots

Attachment 208153 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1402001

[Antti Koivisto]

Created attachment 208169 [details]
bots2

[Early Warning System Bot]

Comment on attachment 208169 [details]
bots2

Attachment 208169 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1358190

[Early Warning System Bot]

Comment on attachment 208169 [details]
bots2

Attachment 208169 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1352091

[Ryosuke Niwa]

Comment on attachment 208169 [details]
bots2

View in context: https://bugs.webkit.org/attachment.cgi?id=208169&action=review

> Source/WebCore/css/StyleRecalculation.h:35
> +namespace Style {

Style might be too generic? How about StyleRecalc or RenderStyleChange?

[EFL EWS Bot]

Comment on attachment 208169 [details]
bots2

Attachment 208169 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1364093

[Build Bot]

Comment on attachment 208169 [details]
bots2

Attachment 208169 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1370410

New failing tests:
css2.1/20110323/at-import-004.htm
css2.1/t040304-c64-uri-00-a-g.html
css2.1/t0603-c11-import-00-b.html
css2.1/20110323/at-import-005.htm
css2.1/20110323/at-import-007.htm
css2.1/t060401-c32-cascading-00-b.html
css2.1/20110323/at-import-009.htm
css1/basic/class_as_selector.html
css1/box_properties/border.html
css1/units/urls.html
css2.1/20110323/at-import-002.htm
css2.1/t040105-atkeyw-00-b.html
compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html
css2.1/20110323/at-import-006.htm
css1/basic/containment.html
compositing/geometry/bounds-ignores-hidden-dynamic.html
css1/cascade/cascade_order.html

[Build Bot]

Created attachment 208170 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Andreas Kling]

Comment on attachment 208169 [details]
bots2

View in context: https://bugs.webkit.org/attachment.cgi?id=208169&action=review

>> Source/WebCore/css/StyleRecalculation.h:35
>> +namespace Style {
> 
> Style might be too generic? How about StyleRecalc or RenderStyleChange?

I like Style. We can then start moving more things to the namespace and migrate a large chunk of css/ to style/

[EFL EWS Bot]

Comment on attachment 208169 [details]
bots2

Attachment 208169 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1361099

[Antti Koivisto]

(In reply to comment #16)
> (From update of attachment 208169 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208169&action=review
> 
> >> Source/WebCore/css/StyleRecalculation.h:35
> >> +namespace Style {
> > 
> > Style might be too generic? How about StyleRecalc or RenderStyleChange?
> 
> I like Style. We can then start moving more things to the namespace and migrate a large chunk of css/ to style/

That would be the plan.

StyleRule -> Style::Rule
StyleResolver -> Style::Resolver

etc.

[Build Bot]

Comment on attachment 208169 [details]
bots2

Attachment 208169 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1354115

New failing tests:
css2.1/20110323/at-import-005.htm
css1/basic/class_as_selector.html
css2.1/20110323/at-import-006.htm
fast/box-sizing/table-cell.html
css2.1/20110323/at-import-009.htm
fast/block/float/015.html
css3/flexbox/flex-no-flex.html
css1/box_properties/border.html
css2.1/20110323/at-import-002.htm
css3/filters/filter-property-computed-style.html
css1/units/urls.html
css1/cascade/cascade_order.html
fast/block/sticky-position-containing-block-crash.html
http/tests/cache/cancel-during-revalidation-succeeded.html
css2.1/20110323/at-import-007.htm
fast/block/margin-collapse/103.html
fast/body-propagation/background-image/008.html
css2.1/t0603-c11-import-00-b.html
compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html
css1/basic/containment.html
compositing/geometry/bounds-ignores-hidden-dynamic.html
css2.1/t040304-c64-uri-00-a-g.html
css2.1/20110323/at-import-004.htm
http/tests/css/css-imports-url-fragment.html
css2.1/t060401-c32-cascading-00-b.html
fast/body-propagation/background-color/008.html
fast/block/float/031.html
css2.1/20110323/eof-005.htm
css2.1/t040105-atkeyw-00-b.html
css1/classification/display.html

[Build Bot]

Created attachment 208176 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Antti Koivisto]

Created attachment 208180 [details]
another

- renamed Style::recalculate -> Style::resolveTree
- fix Force inheritance

[Antti Koivisto]

Created attachment 208181 [details]
yet another

[Early Warning System Bot]

Comment on attachment 208181 [details]
yet another

Attachment 208181 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1354146

[Early Warning System Bot]

Comment on attachment 208181 [details]
yet another

Attachment 208181 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1353143

[EFL EWS Bot]

Comment on attachment 208181 [details]
yet another

Attachment 208181 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1354152

[kov's GTK+ EWS bot]

Comment on attachment 208181 [details]
yet another

Attachment 208181 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1404140

[EFL EWS Bot]

Comment on attachment 208181 [details]
yet another

Attachment 208181 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1351177

[Antti Koivisto]

Created attachment 208200 [details]
now with all build systems

[Andreas Kling]

Comment on attachment 208200 [details]
now with all build systems

r=me

[Antti Koivisto]

https://trac.webkit.org/r153783