Bug 119486

Summary: Update spellcheck-attribute.html description
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: Tools / TestsAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
update description
none
make spellcheck-attribute.html to be more descriptive
none
dump more information rniwa: review+

Description Grzegorz Czajkowski 2013-08-05 07:04:31 PDT
Cleanup.

r70512 r72782 added new fields to spellcheck-attribute.html to verify spellcheck attribute.
Update the description after those changes.
Comment 1 Grzegorz Czajkowski 2013-08-05 07:07:26 PDT
Created attachment 208124 [details]
update description
Comment 2 Ryosuke Niwa 2013-08-07 13:29:59 PDT
Comment on attachment 208124 [details]
update description

View in context: https://bugs.webkit.org/attachment.cgi?id=208124&action=review

> LayoutTests/editing/spelling/spellcheck-attribute.html:7
> -<p>This tests if the "spellcheck" attribute is implemented as written in its specification. If this test succeeds, you can see six forms filled with an invalid word 'zz '. Nevertheless, the 'zz ' only in the line 1.1, 1.2, and 2.2 are marked as misspelled.</p>
> +<p>This tests if the "spellcheck" attribute is implemented as written in its specification. If this test succeeds, you can see twenty-four forms filled with an invalid word 'zz '. Nevertheless, the 'zz ' only in the line 1.1, 1.2, 1.4, 1.5, 1.6, 2.2, 2.5, 3.1, 3.2, 3.4, 3.5, 3.6, 4.2 and 4.5 are marked as misspelled.</p>

I don't think this description is useful. It's basically repeating what we're outputting right beneath it.
Comment 3 Grzegorz Czajkowski 2013-08-08 01:28:05 PDT
(In reply to comment #2)
> (From update of attachment 208124 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208124&action=review
> 
> > LayoutTests/editing/spelling/spellcheck-attribute.html:7
> > -<p>This tests if the "spellcheck" attribute is implemented as written in its specification. If this test succeeds, you can see six forms filled with an invalid word 'zz '. Nevertheless, the 'zz ' only in the line 1.1, 1.2, and 2.2 are marked as misspelled.</p>
> > +<p>This tests if the "spellcheck" attribute is implemented as written in its specification. If this test succeeds, you can see twenty-four forms filled with an invalid word 'zz '. Nevertheless, the 'zz ' only in the line 1.1, 1.2, 1.4, 1.5, 1.6, 2.2, 2.5, 3.1, 3.2, 3.4, 3.5, 3.6, 4.2 and 4.5 are marked as misspelled.</p>
> 
> I don't think this description is useful. It's basically repeating what we're outputting right beneath it.

Not really, we are outputting the series of:
PASS:test1_1
PASS:test1_2
...
PASS:test4_6

How about extending those logs to boolean value whether the test (form) should be underlined to be self descriptive?
Comment 4 Grzegorz Czajkowski 2013-08-08 03:21:37 PDT
Created attachment 208322 [details]
make spellcheck-attribute.html to be more descriptive
Comment 5 Ryosuke Niwa 2013-08-08 11:47:41 PDT
Comment on attachment 208322 [details]
make spellcheck-attribute.html to be more descriptive

View in context: https://bugs.webkit.org/attachment.cgi?id=208322&action=review

> LayoutTests/editing/spelling/spellcheck-attribute-expected.txt:3
> +PASS:test1_1 marked:true

This output isn't meaningful to me. It doesn't tell me why marked should be true or false.
We need to be dumping the markup of the input element or something.
Otherwise, it's impossible to tell what this test is testing.
Comment 6 Grzegorz Czajkowski 2013-08-09 05:22:07 PDT
Created attachment 208417 [details]
dump more information

Added more logs (element's spellcheck value and parent one) to show how spellcheck attribute affects markers for the misspelled word.
However, I am not sure if those logs are not exaggerated:
id:test1_1 type:text spellcheck:true parent's spellcheck:true
PASS internals.hasSpellingMarker(document, 0, 2) is true
Comment 7 Grzegorz Czajkowski 2013-08-12 00:56:33 PDT
Committed r153932: <http://trac.webkit.org/changeset/153932>